r26387 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r26386‎ | r26387 | r26388 >
Date:21:13, 3 October 2007
Author:brion
Status:old
Tags:
Comment:
Fix for regression from r26357: send newtalk notifications only if user has that pref selected
Modified paths:
  • /trunk/phase3/includes/UserMailer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/UserMailer.php
@@ -348,9 +348,12 @@
349349 wfDebug( __METHOD__.": user talk page edited, but user does not exist\n" );
350350 } elseif ( $targetUser->getId() == $editor->getId() ) {
351351 wfDebug( __METHOD__.": user edited their own talk page, no notification sent\n" );
352 - } else {
 352+ } elseif( $targetUser->getOption( 'enotifusertalkpages' ) ) {
 353+ wfDebug( __METHOD__.": sending talk page update notification\n" );
353354 $this->compose( $targetUser );
354355 $userTalkId = $targetUser->getId();
 356+ } else {
 357+ wfDebug( __METHOD__.": talk page owner doesn't want notifications\n" );
355358 }
356359 }
357360

Follow-up revisions

RevisionCommit summaryAuthorDate
r26431Merged revisions 26331-26430 via svnmerge from...david06:44, 5 October 2007

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r26357WARNING! NEEDS CAREFUL DEPLOYMENT...tstarling08:46, 3 October 2007

Status & tagging log