r26355 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r26354‎ | r26355 | r26356 >
Date:08:20, 3 October 2007
Author:erik
Status:old
Tags:
Comment:
simplify simple UI further: when current & stable version are identical, show a different message & the stable icon.
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedArticle.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/FlaggedRevsPage.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedArticle.php
@@ -82,10 +82,17 @@
8383 # Construct some tagging
8484 if( !$wgOut->isPrintable() ) {
8585 if( $this->useSimpleUI() ) {
86 - $msg = $quality ? 'revreview-quick-see-quality' : 'revreview-quick-see-basic';
87 - $tag .= "<span class='fr_tab_current plainlinks'></span>" .
88 - wfMsgExt($msg,array('parseinline'), $tfrev->fr_rev_id, $revs_since);
89 - $tag .= $this->prettyRatingBox( $tfrev, $flags, $revs_since, false );
 86+ if($revs_since) {
 87+ $msg = $quality ? 'revreview-quick-see-quality' : 'revreview-quick-see-basic';
 88+ $tag .= "<span class='fr_tab_current plainlinks'></span>" .
 89+ wfMsgExt($msg,array('parseinline'), $tfrev->fr_rev_id, $revs_since);
 90+ } else {
 91+ $msg = $quality ? 'revreview-quick-seeandis-quality': 'revreview-quick-seeandis-basic';
 92+ $css = $quality ? 'fr_tab_quality' : 'fr_tab_stable';
 93+ $tag .= "<span class='$css'></span>" .
 94+ wfMsgExt($msg,array('parseinline'));
 95+ }
 96+ $tag .= $this->prettyRatingBox( $tfrev, $flags, $revs_since, false );
9097 } else {
9198 $msg = $quality ? 'revreview-newest-quality' : 'revreview-newest-basic';
9299 $tag .= wfMsgExt($msg, array('parseinline'), $tfrev->fr_rev_id, $time, $revs_since);
@@ -633,7 +640,6 @@
634641 $box .= $encRatingLabel . self::addTagRatings( $flags, true, "{$tagClass}a" );
635642 }
636643 $box .= '</span>';
637 -
638644 return $box;
639645 }
640646
Index: trunk/extensions/FlaggedRevs/FlaggedRevsPage.i18n.php
@@ -27,6 +27,8 @@
2828 ($2 [{{fullurl:{{FULLPAGENAMEE}}|oldid=$1&diff=cur&editreview=1}} {{plural:$2|change|changes}}])',
2929 'revreview-quick-see-basic' => '\'\'\'Current\'\'\'. [[{{fullurl:{{FULLPAGENAMEE}}|stable=1}} see stable revision]]
3030 ($2 [{{fullurl:{{FULLPAGENAMEE}}|oldid=$1&diff=cur&editreview=1}} {{plural:$2|change|changes}}])',
 31+ 'revreview-quick-seeandis-quality' => '\'\'\'Current revision, [[Help:Article validation|quality]] reviewed.\'\'\'',
 32+ 'revreview-quick-seeandis-basic' => '\'\'\'Current revision, [[Help:Article validation|sighted]] for vandalism.\'\'\'',
3133 'revreview-quick-basic' => '\'\'\'[[Help:Article validation|Sighted]]\'\'\'. [[{{fullurl:{{FULLPAGENAMEE}}|stable=0}} see current revision]]
3234 ($2 [{{fullurl:{{FULLPAGENAMEE}}|oldid=$1&diff=cur&editreview=1}} {{plural:$2|change|changes}}])',
3335 'revreview-quick-quality' => '\'\'\'[[Help:Article validation|Quality]]\'\'\'. [[{{fullurl:{{FULLPAGENAMEE}}|stable=0}} see current revision]]

Status & tagging log