r26349 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r26348‎ | r26349 | r26350 >
Date:03:12, 3 October 2007
Author:tstarling
Status:old
Tags:
Comment:
Applying cortado-tweak.diff: don't use static class variables.
Modified paths:
  • /trunk/extensions/OggHandler/cortado/src/com/fluendo/player/Cortado.java (modified) (history)

Diff [purge]

Index: trunk/extensions/OggHandler/cortado/src/com/fluendo/player/Cortado.java
@@ -30,8 +30,8 @@
3131 MouseListener, ComponentListener, BusHandler, StatusListener, ActionListener {
3232 private static final long serialVersionUID = 1L;
3333
34 - private static Cortado cortado;
35 - private static CortadoPipeline pipeline;
 34+ private Cortado cortado;
 35+ private CortadoPipeline pipeline;
3636
3737 private String urlString;
3838 private boolean audio;
@@ -192,10 +192,10 @@
193193 return res;
194194 }
195195
196 - public static void shutDown(Throwable error) {
 196+ public void shutDown(Throwable error) {
197197 Debug.log(Debug.INFO, "shutting down: reason: " + error.getMessage());
198198 error.printStackTrace();
199 - cortado.stop();
 199+ stop();
200200 }
201201
202202 public synchronized void init() {
@@ -341,7 +341,7 @@
342342 try {
343343 realRun();
344344 } catch (Throwable t) {
345 - Cortado.shutDown(t);
 345+ shutDown(t);
346346 }
347347 }
348348

Status & tagging log