r26345 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r26344‎ | r26345 | r26346 >
Date:01:27, 3 October 2007
Author:aaron
Status:old
Tags:
Comment:
*Allow tags to be empty
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevsPage_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevsPage_body.php
@@ -82,8 +82,8 @@
8383 # Users can't take away a status they can't set
8484 $wgOut->permissionRequired( 'badaccess-group0' );
8585 return;
 86+ // Users cannot review to beyond their rights level
8687 } else if( !$this->userCan( $tag, $this->dims[$tag] ) ) {
87 - // Users cannot review to beyond their rights level
8888 $wgOut->permissionRequired( 'badaccess-group0' );
8989 return;
9090 }
@@ -234,9 +234,9 @@
235235 }
236236
237237 function submit( $request ) {
238 - global $wgOut, $wgUser, $wgFlaggedRevs;
 238+ global $wgOut, $wgUser, $wgFlaggedRevs, $wgFlaggedRevTags;
239239 # If all values are set to zero, this has been unapproved
240 - $approved = false;
 240+ $approved = empty($wgFlaggedRevTags);
241241 foreach( $this->dims as $quality => $value ) {
242242 if( $value ) {
243243 $approved = true;

Status & tagging log