r26326 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r26325‎ | r26326 | r26327 >
Date:21:54, 2 October 2007
Author:tango
Status:old
Tags:
Comment:
Correcting r26045, references with no text which are used multiple times should still link back to each use, rather than just the last one.
Modified paths:
  • /trunk/extensions/Cite/Cite.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Cite/Cite.php
@@ -394,7 +394,7 @@
395395 'cite_references_link_one',
396396 $this->referencesKey( $key ),
397397 $this->refKey( $key, $val['count'] ),
398 - $val['text']
 398+ ($val['text']!=''?$val['text']:$this->error(CITE_ERROR_REFERENCES_NO_TEXT))
399399 );
400400 // Named references with >1 occurrences
401401 else {
@@ -415,7 +415,7 @@
416416 wfMsgForContentNoTrans( 'cite_references_link_many',
417417 $this->referencesKey( $key ),
418418 $list,
419 - $val['text']
 419+ ($val['text']!=''?$val['text']:$this->error(CITE_ERROR_REFERENCES_NO_TEXT))
420420 );
421421 }
422422 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r26045(bug 11426) Give error if no text is supplied for a reference. Patch by Thom...simetrical23:38, 23 September 2007

Status & tagging log