r26315 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r26314‎ | r26315 | r26316 >
Date:15:30, 2 October 2007
Author:catrope
Status:old
Tags:
Comment:
(bug 11534) rvendid doesn't work
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryRevisions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryRevisions.php
@@ -53,6 +53,7 @@
5454 // Enumerating revisions on multiple pages make it extremelly
5555 // difficult to manage continuations and require additional sql indexes
5656 $enumRevMode = (!is_null($user) || !is_null($excludeuser) || !is_null($limit) || !is_null($startid) || !is_null($endid) || $dir === 'newer' || !is_null($start) || !is_null($end));
 57+
5758
5859 $pageSet = $this->getPageSet();
5960 $pageCount = $pageSet->getGoodTitleCount();
@@ -133,7 +134,7 @@
134135 // one row with the same timestamp for the same page.
135136 // The order needs to be the same as start parameter to avoid SQL filesort.
136137
137 - if (is_null($startid))
 138+ if (is_null($startid) && is_null($endid))
138139 $this->addWhereRange('rev_timestamp', $dir, $start, $end);
139140 else
140141 $this->addWhereRange('rev_id', $dir, $startid, $endid);
Index: trunk/phase3/RELEASE-NOTES
@@ -95,6 +95,7 @@
9696 * (bug 11218) Add option to feedwatchlist to display multiple revisions for each page.
9797 * (bug 11404) Provide name of exception caught in error code field of internal api
9898 error messages.
 99+* (bug 11534) rvendid doesn't work
99100
100101 === Languages updated in 1.12 ===
101102

Follow-up revisions

RevisionCommit summaryAuthorDate
r26331Merged revisions 26280-26330 via svnmerge from...david22:28, 2 October 2007

Status & tagging log