r26232 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r26231‎ | r26232 | r26233 >
Date:23:56, 28 September 2007
Author:aaron
Status:old
Tags:
Comment:
*Don't add redundant perm errors, as the text can get doubled up on edit
Modified paths:
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -318,9 +318,9 @@
319319 return;
320320 }
321321
322 - $permErrors = $this->mTitle->getUserPermissionsErrors( 'edit', $wgUser);
 322+ $permErrors = $this->mTitle->getUserPermissionsErrors('edit', $wgUser);
323323 if( !$this->mTitle->exists() )
324 - $permErrors += $this->mTitle->getUserPermissionsErrors( 'create', $wgUser);
 324+ $permErrors += array_diff( $this->mTitle->getUserPermissionsErrors('create', $wgUser), $permErrors );
325325
326326 # Ignore some permissions errors.
327327 $remove = array();

Follow-up revisions

RevisionCommit summaryAuthorDate
r26257Merged revisions 26134-26247 via svnmerge from...david19:06, 30 September 2007

Status & tagging log