r26187 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r26186‎ | r26187 | r26188 >
Date:18:35, 27 September 2007
Author:aaron
Status:old
Tags:
Comment:
*Kill redundant checkbox
Modified paths:
  • /trunk/extensions/ConfirmAccount/ConfirmAccount.i18n.php (modified) (history)
  • /trunk/extensions/ConfirmAccount/ConfirmAccount_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ConfirmAccount/ConfirmAccount_body.php
@@ -37,7 +37,6 @@
3838 $this->mBio = $wgRequest->getText( 'wpBio', '' );
3939 $this->mNotes = $wgRequest->getText( 'wpNotes', '' );
4040 $this->mUrls = $wgRequest->getText( 'wpUrls', '' );
41 - $this->mCorrect = $wgRequest->getBool('wpCorrect');
4241 $this->mToS = $wgRequest->getBool('wpToS');
4342 # We may be confirming an email address here
4443 $emailCode = $wgRequest->getText( 'wpEmailToken' );
@@ -122,8 +121,6 @@
123122 $form .= '</fieldset>';
124123 }
125124 }
126 - $form .= "<p>".Xml::checkLabel( wfMsgExt( 'requestaccount-correct',
127 - array('parseinline') ), 'wpCorrect', 'wpCorrect', $this->mCorrect )."</p>\n";
128125 $form .= "<p>".Xml::checkLabel( wfMsgExt( 'requestaccount-tos',
129126 array('parseinline') ), 'wpToS', 'wpToS', $this->mToS )."</p>\n";
130127 $form .= Xml::hidden( 'title', $wgTitle->getPrefixedText() )."\n";
@@ -159,7 +156,7 @@
160157 return;
161158 }
162159 # Make sure user agrees to policy here
163 - if( !$this->mCorrect || !$this->mToS ) {
 160+ if( !$this->mToS ) {
164161 $this->showForm( wfMsgHtml('requestaccount-agree') );
165162 return;
166163 }
Index: trunk/extensions/ConfirmAccount/ConfirmAccount.i18n.php
@@ -35,8 +35,8 @@
3636 'requestaccount-agree' => 'You must certify that your real name is correct and that you agree to our Terms of Service.',
3737 'requestaccount-inuse' => 'Username is already in use in a pending account request.',
3838 'requestaccount-tooshort' => 'Your biography must be at least be $1 words long.',
39 - 'requestaccount-tos' => 'I have read and agree to abide by the Terms of Service of {{SITENAME}}.',
40 - 'requestaccount-correct' => 'I certify that the name I have specified under "Real name" is in fact my own real name.',
 39+ 'requestaccount-tos' => 'I have read and agree to abide by the Terms of Service of {{SITENAME}}. The name I have specified
 40+ under "Real name" is in fact my own real name.',
4141 'requestacount-submit' => 'Request account',
4242 'requestaccount-sent' => 'Your account request has successfully been sent and is now pending review.',
4343 'request-account-econf' => 'Your e-mail address has been confirmed and will be listed as such in your account

Status & tagging log