r25880 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25879‎ | r25880 | r25881 >
Date:12:42, 16 September 2007
Author:robchurch
Status:old
Tags:
Comment:
Further clarify $wgSquidServers/$wgSquidServersNoPurge documentation - state that both are "trusted" with regards to X-Forwarded-For, etc.
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/DefaultSettings.php
@@ -1334,15 +1334,19 @@
13351335 $wgSquidMaxage = 18000;
13361336
13371337 /**
1338 - * A list of proxy servers (ips if possible) to purge on changes don't specify
1339 - * ports here (80 is default). When mediawiki is running behind a proxy, its
1340 - * address should be listed in $wgSquidServers otherwise mediawiki won't rely
1341 - * on the X-FORWARDED-FOR header to determine the user IP address and
1342 - * all users will appear to come from the proxy IP address. Don't use domain
1343 - * names here, only IP adresses.
 1338+ * List of proxy servers to purge on changes; default port is 80. Use IP addresses.
 1339+ *
 1340+ * When MediaWiki is running behind a proxy, it will trust X-Forwarded-For
 1341+ * headers sent/modified from these proxies when obtaining the remote IP address
 1342+ *
 1343+ * For a list of trusted servers which *aren't* purged, see $wgSquidServersNoPurge.
13441344 */
1345 -# $wgSquidServers = array('127.0.0.1');
13461345 $wgSquidServers = array();
 1346+
 1347+/**
 1348+ * As above, except these servers aren't purged on page changes; use to set a
 1349+ * list of trusted proxies, etc.
 1350+ */
13471351 $wgSquidServersNoPurge = array();
13481352
13491353 /** Maximum number of titles to purge in any one client operation */

Follow-up revisions

RevisionCommit summaryAuthorDate
r25932Merged revisions 25861-25931 via svnmerge from...david06:43, 19 September 2007

Status & tagging log