r25877 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25876‎ | r25877 | r25878 >
Date:03:38, 16 September 2007
Author:rotem
Status:old
Tags:
Comment:
Strike the link to the redirect rather than using an asterisk in Special:Listredirects
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SpecialListredirects.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialListredirects.php
@@ -30,8 +30,7 @@
3131
3232 # Make a link to the redirect itself
3333 $rd_title = Title::makeTitle( $result->namespace, $result->title );
34 - $arr = $wgContLang->getArrow() . $wgContLang->getDirMark();
35 - $rd_link = $skin->makeKnownLinkObj( $rd_title, '', 'redirect=no' );
 34+ $rd_link = $skin->makeLinkObj( $rd_title, '', 'redirect=no' );
3635
3736 # Find out where the redirect leads
3837 $revision = Revision::newFromTitle( $rd_title );
@@ -39,19 +38,15 @@
4039 # Make a link to the destination page
4140 $target = Title::newFromRedirect( $revision->getText() );
4241 if( $target ) {
 42+ $arr = $wgContLang->getArrow() . $wgContLang->getDirMark();
4343 $targetLink = $skin->makeLinkObj( $target );
 44+ return "$rd_link $arr $targetLink";
4445 } else {
45 - /** @todo Put in some decent error display here */
46 - $targetLink = '*';
 46+ return "<s>$rd_link</s>";
4747 }
4848 } else {
49 - /** @todo Put in some decent error display here */
50 - $targetLink = '*';
 49+ return "<s>$rd_link</s>";
5150 }
52 -
53 - # Format the whole thing and return it
54 - return "$rd_link $arr $targetLink";
55 -
5651 }
5752
5853 }
Index: trunk/phase3/RELEASE-NOTES
@@ -56,6 +56,7 @@
5757 * Fix initial statistics when installing: add correct values
5858 * (bug 11342) Fix several 'returnto' links in permissions/error pages which
5959 linked to the main page instead of targetted page
 60+* Strike the link to the redirect rather than using an asterisk in Special:Listredirects
6061
6162
6263 === API changes in 1.12 ===

Follow-up revisions

RevisionCommit summaryAuthorDate
r25932Merged revisions 25861-25931 via svnmerge from...david06:43, 19 September 2007

Status & tagging log