r25876 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25875‎ | r25876 | r25877 >
Date:03:25, 16 September 2007
Author:rotem
Status:old
Tags:
Comment:
In double redirects, the link should be red when the page was deleted, as in broken redirects, and not always known.
Modified paths:
  • /trunk/phase3/includes/SpecialDoubleRedirects.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialDoubleRedirects.php
@@ -63,7 +63,6 @@
6464
6565 $fname = 'DoubleRedirectsPage::formatResult';
6666 $titleA = Title::makeTitle( $result->namespace, $result->title );
67 - $linkA = $skin->makeKnownLinkObj( $titleA,'', 'redirect=no' );
6867
6968 if ( $result && !isset( $result->nsb ) ) {
7069 $dbr = wfGetDB( DB_SLAVE );
@@ -75,12 +74,13 @@
7675 }
7776 }
7877 if ( !$result ) {
79 - return "<s>{$linkA}</s>\n";
 78+ return '<s>' . $skin->makeLinkObj( $titleA, '', 'redirect=no' ) . '</s>';
8079 }
8180
8281 $titleB = Title::makeTitle( $result->nsb, $result->tb );
8382 $titleC = Title::makeTitle( $result->nsc, $result->tc );
8483
 84+ $linkA = $skin->makeKnownLinkObj( $titleA, '', 'redirect=no' );
8585 $edit = $skin->makeBrokenLinkObj( $titleA, "(".wfMsg("qbedit").")" , 'redirect=no');
8686 $linkB = $skin->makeKnownLinkObj( $titleB, '', 'redirect=no' );
8787 $linkC = $skin->makeKnownLinkObj( $titleC );

Follow-up revisions

RevisionCommit summaryAuthorDate
r25932Merged revisions 25861-25931 via svnmerge from...david06:43, 19 September 2007
r26074apiedit: Merging r25876 and beyond from trunkcatrope14:26, 24 September 2007

Status & tagging log