r25848 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25847‎ | r25848 | r25849 >
Date:06:50, 14 September 2007
Author:david
Status:old
Tags:
Comment:
oops
Modified paths:
  • /branches/liquidthreads/extensions/LqtModel.php (modified) (history)

Diff [purge]

Index: branches/liquidthreads/extensions/LqtModel.php
@@ -1006,13 +1006,13 @@
10071007 else if( is_integer($user) ) $user_id = $user;
10081008 else throw new MWException("writeUserMessageState expected User or integer but got $user");
10091009
 1010+ if ( $timestamp === null ) $timestamp = "NULL";
 1011+
10101012 // use query() directly to pass is 'true' for don't-die on errors.
10111013 $dbr =& wfGetDB( DB_MASTER );
10121014 $success = $dbr->query("insert into user_message_state values ($user_id, $thread_id, $timestamp)",
10131015 __METHOD__, true);
10141016
1015 - if ( $timestamp === null ) $timestamp = "NULL";
1016 -
10171017 if( !$success ) {
10181018 // duplicate key; update.
10191019 $dbr->query("update user_message_state set ums_read_timestamp = $timestamp" .

Status & tagging log