r25741 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25740‎ | r25741 | r25742 >
Date:20:19, 10 September 2007
Author:brion
Status:old
Tags:
Comment:
When searching through a big checkuser log, don't give up when we didn't find newlines in the buffer.
That probably just means we hit a big block of null bytes, probably due to NFS conflicts.
Keep on reading, there'll be more lines. :)
Modified paths:
  • /trunk/extensions/CheckUser/CheckUser_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CheckUser/CheckUser_body.php
@@ -683,7 +683,9 @@
684684 $leftover = $parts[0];
685685 } else {
686686 $leftover = '';
687 - break;
 687+ // Don't give up if there's still space in the file.
 688+ // We sometimes get big blocks of 0s in the file,
 689+ // probably due to conflicts via NFS.
688690 }
689691 } while( $filePosition > 0 );
690692 # leftover

Status & tagging log