r25737 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25736‎ | r25737 | r25738 >
Date:18:28, 10 September 2007
Author:mkroetzsch
Status:old
Tags:
Comment:
Copy printrequests from subqueries
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/storage/SMW_Description.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/storage/SMW_Description.php
@@ -521,6 +521,10 @@
522522 public function addDescription(SMWDescription $description) {
523523 if (! ($description instanceof SMWThingDescription) ) {
524524 $this->m_descriptions[] = $description;
 525+ // move print descriptions downwards
 526+ ///TODO: This may not be a good solution, since it does modify $description and since it does not react to future cahges
 527+ $this->m_printreqs = array_merge($this->m_printreqs, $description->getPrintRequests());
 528+ $description->setPrintRequests(array());
525529 }
526530 }
527531
@@ -627,8 +631,11 @@
628632 } else {
629633 $this->m_descriptions[] = $description;
630634 }
631 -
632635 }
 636+ // move print descriptions downwards
 637+ ///TODO: This may not be a good solution, since it does modify $description and since it does not react to future cahges
 638+ $this->m_printreqs = array_merge($this->m_printreqs, $description->getPrintRequests());
 639+ $description->setPrintRequests(array());
633640 }
634641
635642 public function getQueryString() {

Status & tagging log