r25733 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25732‎ | r25733 | r25734 >
Date:16:19, 10 September 2007
Author:brion
Status:old
Tags:
Comment:
De-uglify <button> in Safari 2/Mac a bit... Contents weren't being centered automatically.
The button is still unattractive and badly sized (as other block elements, the margin, padding, and border lengths are in addition to the 'width', contrary to the default behavior other browsers and Safari 3 seem to give, so the button is wider than the video by a few pixels.)
Modified paths:
  • /trunk/extensions/OggHandler/OggHandler_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OggHandler/OggHandler_body.php
@@ -567,7 +567,7 @@
568568 Xml::tags( 'button',
569569 array(
570570 'onclick' => "wgOggPlayer.init(false, $playerParams);",
571 - 'style' => "width: {$width}px;",
 571+ 'style' => "width: {$width}px; text-align: center",
572572 'title' => $msgStartPlayer,
573573 ),
574574 Xml::element( 'img',

Status & tagging log