r25705 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25704‎ | r25705 | r25706 >
Date:23:58, 9 September 2007
Author:simetrical
Status:old
Tags:
Comment:
Moved inline markup in signup and login forms to CSS, and dealt with some of the associated directionality issues in the process.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/templates/Userlogin.php (modified) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/shared.css
@@ -46,3 +46,16 @@
4747 table.filehistory th.mw-imagepage-filesize {
4848 white-space:nowrap;
4949 }
 50+
 51+/**
 52+ * Forms
 53+ */
 54+body.ltr td.mw-label { text-align: right; }
 55+body.ltr td.mw-input { text-align: left; }
 56+body.ltr td.mw-submit { text-align: left; }
 57+body.rtl td.mw-label { text-align: left; }
 58+body.rtl td.mw-input { text-align: right; }
 59+body.rtl td.mw-submit { text-align: right; }
 60+
 61+td.mw-label { vertical-align: top; }
 62+td.mw-submit { white-space: nowrap; }
Index: trunk/phase3/includes/DefaultSettings.php
@@ -1214,7 +1214,7 @@
12151215 * to ensure that client-side caches don't keep obsolete copies of global
12161216 * styles.
12171217 */
1218 -$wgStyleVersion = '97';
 1218+$wgStyleVersion = '98';
12191219
12201220
12211221 # Server-side caching:
Index: trunk/phase3/includes/templates/Userlogin.php
@@ -33,16 +33,16 @@
3434 <?php if( @$this->haveData( 'languages' ) ) { ?><div id="languagelinks"><p><?php $this->html( 'languages' ); ?></p></div><?php } ?>
3535 <table>
3636 <tr>
37 - <td align='right'><label for='wpName1'><?php $this->msg('yourname') ?></label></td>
38 - <td align='left'>
 37+ <td class="mw-label"><label for='wpName1'><?php $this->msg('yourname') ?></label></td>
 38+ <td class="mw-input">
3939 <input type='text' class='loginText' name="wpName" id="wpName1"
4040 tabindex="1"
4141 value="<?php $this->text('name') ?>" size='20' />
4242 </td>
4343 </tr>
4444 <tr>
45 - <td align='right'><label for='wpPassword1'><?php $this->msg('yourpassword') ?></label></td>
46 - <td align='left'>
 45+ <td class="mw-label"><label for='wpPassword1'><?php $this->msg('yourpassword') ?></label></td>
 46+ <td class="mw-input">
4747 <input type='password' class='loginPassword' name="wpPassword" id="wpPassword1"
4848 tabindex="2"
4949 value="" size='20' />
@@ -55,8 +55,8 @@
5656 }
5757 ?>
5858 <tr>
59 - <td align='right'><?php $this->msg( 'yourdomainname' ) ?></td>
60 - <td align='left'>
 59+ <td class="mw-label"><?php $this->msg( 'yourdomainname' ) ?></td>
 60+ <td class="mw-input">
6161 <select name="wpDomain" value="<?php $this->text( 'domain' ) ?>"
6262 tabindex="3">
6363 <?php echo $doms ?>
@@ -66,7 +66,7 @@
6767 <?php } ?>
6868 <tr>
6969 <td></td>
70 - <td align='left'>
 70+ <td class="mw-input">
7171 <input type='checkbox' name="wpRemember"
7272 tabindex="4"
7373 value="1" id="wpRemember"
@@ -76,7 +76,7 @@
7777 </tr>
7878 <tr>
7979 <td></td>
80 - <td align='left' style="white-space:nowrap">
 80+ <td class="mw-submit">
8181 <input type='submit' name="wpLoginattempt" id="wpLoginattempt" tabindex="5" value="<?php $this->msg('login') ?>" />&nbsp;<?php if( $this->data['useemail'] && $this->data['canreset']) { ?><input type='submit' name="wpMailmypassword" id="wpMailmypassword"
8282 tabindex="6"
8383 value="<?php $this->msg('mailmypassword') ?>" />
@@ -117,16 +117,16 @@
118118 <?php if( @$this->haveData( 'languages' ) ) { ?><div id="languagelinks"><p><?php $this->html( 'languages' ); ?></p></div><?php } ?>
119119 <table>
120120 <tr>
121 - <td align='right'><label for='wpName2'><?php $this->msg('yourname') ?></label></td>
122 - <td align='left'>
 121+ <td class="mw-label"><label for='wpName2'><?php $this->msg('yourname') ?></label></td>
 122+ <td class="mw-input">
123123 <input type='text' class='loginText' name="wpName" id="wpName2"
124124 tabindex="1"
125125 value="<?php $this->text('name') ?>" size='20' />
126126 </td>
127127 </tr>
128128 <tr>
129 - <td align='right'><label for='wpPassword2'><?php $this->msg('yourpassword') ?></label></td>
130 - <td align='left'>
 129+ <td class="mw-label"><label for='wpPassword2'><?php $this->msg('yourpassword') ?></label></td>
 130+ <td class="mw-input">
131131 <input type='password' class='loginPassword' name="wpPassword" id="wpPassword2"
132132 tabindex="2"
133133 value="" size='20' />
@@ -139,8 +139,8 @@
140140 }
141141 ?>
142142 <tr>
143 - <td align='right'><?php $this->msg( 'yourdomainname' ) ?></td>
144 - <td align='left'>
 143+ <td class="mw-label"><?php $this->msg( 'yourdomainname' ) ?></td>
 144+ <td class="mw-input">
145145 <select name="wpDomain" value="<?php $this->text( 'domain' ) ?>"
146146 tabindex="3">
147147 <?php echo $doms ?>
@@ -149,8 +149,8 @@
150150 </tr>
151151 <?php } ?>
152152 <tr>
153 - <td align='right'><label for='wpRetype'><?php $this->msg('yourpasswordagain') ?></label></td>
154 - <td align='left'>
 153+ <td class="mw-label"><label for='wpRetype'><?php $this->msg('yourpasswordagain') ?></label></td>
 154+ <td class="mw-input">
155155 <input type='password' class='loginPassword' name="wpRetype" id="wpRetype"
156156 tabindex="4"
157157 value=""
@@ -159,8 +159,8 @@
160160 </tr>
161161 <tr>
162162 <?php if( $this->data['useemail'] ) { ?>
163 - <td align='right' style='vertical-align: top'><label for='wpEmail'><?php $this->msg('youremail') ?></label></td>
164 - <td align='left'>
 163+ <td class="mw-label"><label for='wpEmail'><?php $this->msg('youremail') ?></label></td>
 164+ <td class="mw-input">
165165 <input type='text' class='loginText' name="wpEmail" id="wpEmail"
166166 tabindex="5"
167167 value="<?php $this->text('email') ?>" size='20' />
@@ -172,8 +172,8 @@
173173 <?php if( $this->data['userealname'] ) { ?>
174174 </tr>
175175 <tr>
176 - <td align='right' style='vertical-align: top'><label for='wpRealName'><?php $this->msg('yourrealname') ?></label></td>
177 - <td align='left'>
 176+ <td class="mw-label"><label for='wpRealName'><?php $this->msg('yourrealname') ?></label></td>
 177+ <td class="mw-input">
178178 <input type='text' class='loginText' name="wpRealName" id="wpRealName"
179179 tabindex="6"
180180 value="<?php $this->text('realname') ?>" size='20' />
@@ -185,7 +185,7 @@
186186 </tr>
187187 <tr>
188188 <td></td>
189 - <td align='left'>
 189+ <td class="mw-input">
190190 <input type='checkbox' name="wpRemember"
191191 tabindex="7"
192192 value="1" id="wpRemember"
@@ -195,7 +195,7 @@
196196 </tr>
197197 <tr>
198198 <td></td>
199 - <td align='left'>
 199+ <td class="mw-submit">
200200 <input type='submit' name="wpCreateaccount" id="wpCreateaccount"
201201 tabindex="8"
202202 value="<?php $this->msg('createaccount') ?>" />
Index: trunk/phase3/RELEASE-NOTES
@@ -30,6 +30,7 @@
3131 ImageMagick, diff3 et al. during installation [patch by Jan Reininghaus]
3232 * (bug 7027) Shift handling of deletion permissions-checking to
3333 getUserPermissionsErrors.
 34+* Login and signup forms are now more correct for right-to-left languages.
3435
3536 === API changes in 1.12 ===
3637

Follow-up revisions

RevisionCommit summaryAuthorDate
r25754Merged revisions 25607-25751 via svnmerge from...david23:02, 10 September 2007

Status & tagging log