r25702 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25701‎ | r25702 | r25703 >
Date:19:57, 9 September 2007
Author:nikerabbit
Status:old
Tags:
Comment:
* Small fixes
Modified paths:
  • /trunk/extensions/Translate/MessageGroups.php (modified) (history)
  • /trunk/extensions/Translate/Translate.php (modified) (history)
  • /trunk/extensions/Translate/TranslateEditAddons.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/MessageGroups.php
@@ -971,7 +971,7 @@
972972 protected $exportEnd = '),';
973973 }
974974
975 -class PageByExtensionGroup extends MultipleFileMessageGroup {
 975+class PageByMessageGroup extends MultipleFileMessageGroup {
976976 protected $label = 'Extension: Page By';
977977 protected $id = 'ext-pageby';
978978
Index: trunk/extensions/Translate/TranslateEditAddons.php
@@ -23,6 +23,7 @@
2424 */
2525
2626 private static function doBox( $msg, $code, $i18nmsg ) {
 27+ global $wgUser;
2728 static $names = false;
2829 if (!$names ) { $names = Language::getLanguageNames(); }
2930 if (!$msg ) { return ''; }
@@ -30,6 +31,7 @@
3132 $prettyCode = TranslateUtils::prettyCode( $code );
3233
3334 /* Approximate row count */
 35+ $cols = $wgUser->getOption( 'cols' );
3436 $rows = count(explode("\n", $msg)) -1;
3537 $rows = max(3, min(15, $rows));
3638
@@ -37,7 +39,7 @@
3840
3941 return
4042 wfMsg( $i18nmsg, $names[$code], $prettyCode ) . " " .
41 - Xml::Element( 'textarea', array( 'rows' => $rows ), $msg );
 43+ Xml::Element( 'textarea', array( 'rows' => $rows, 'cols' => $cols ), $msg );
4244 }
4345
4446 /**
Index: trunk/extensions/Translate/Translate.php
@@ -90,7 +90,7 @@
9191 'ext-newusernotif' => 'NewUserNotifMessageGroup',
9292 'ext-ogghandler' => 'OggHandlerMessageGroup',
9393 'ext-oversight' => 'OversightMessageGroup',
94 -'ext-pageby' => 'PageByExtensionGroup',
 94+'ext-pageby' => 'PageByMessageGroup',
9595 'ext-passwordreset' => 'PasswordResetMessageGroup',
9696 'ext-parserfunctions' => 'ParserfunctionsMessageGroup',
9797 'ext-patroller' => 'PatrollerMessageGroup',

Status & tagging log