r25696 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25695‎ | r25696 | r25697 >
Date:18:31, 9 September 2007
Author:greg
Status:old
Tags:
Comment:
Don't pass getTimestamp output directly to the db without a wrap.
Modified paths:
  • /trunk/phase3/includes/DifferenceEngine.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/DifferenceEngine.php
@@ -166,11 +166,12 @@
167167 $rcid = $this->mRcidMarkPatrolled;
168168 } else {
169169 // Look for an unpatrolled change corresponding to this diff
 170+ $db = wfGetDB( DB_SLAVE );
170171 $change = RecentChange::newFromConds(
171172 array(
172173 // Add redundant timestamp condition so we can use the
173174 // existing index
174 - 'rc_timestamp' => $this->mNewRev->getTimestamp(),
 175+ 'rc_timestamp' => $db->timestamp( $this->mNewRev->getTimestamp() ),
175176 'rc_this_oldid' => $this->mNewid,
176177 'rc_last_oldid' => $this->mOldid,
177178 'rc_patrolled' => 0,

Follow-up revisions

RevisionCommit summaryAuthorDate
r25754Merged revisions 25607-25751 via svnmerge from...david23:02, 10 September 2007

Status & tagging log