r25637 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25636‎ | r25637 | r25638 >
Date:13:52, 7 September 2007
Author:brion
Status:old
Tags:
Comment:
Some naming cleanup of the filename prefix blacklist added in r25620:
* Dropped a redundant if(count()) around a foreach().
* Renamed SpecialUpload::getFilenamePrefix() to getFilenamePrefixBlacklist(), since it returns a blacklist of filename prefixes, not the prefix of a filename. :)
* Renamed some local variables to match
* Renamed 'filename-prefix' message to 'filename-bad-prefix' and 'filename-prefix-list' to 'filename-prefix-blacklist' to clarify usage.
Modified paths:
  • /trunk/phase3/includes/SpecialUpload.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesDa.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesDe.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -824,8 +824,8 @@
825825 'destfilename',
826826 'watchthisupload',
827827 'filewasdeleted',
828 - 'filename-prefix',
829 - 'filename-prefix-list',
 828+ 'filename-bad-prefix',
 829+ 'filename-prefix-blacklist',
830830 ),
831831 'upload-errors' => array(
832832 'upload-proto-error',
Index: trunk/phase3/includes/SpecialUpload.php
@@ -543,14 +543,12 @@
544544 }
545545 }
546546
547 - $filenamePrefix = self::getFilenamePrefix();
548 - if ( count( $filenamePrefix ) ) {
549 - # Do the match
550 - foreach( $filenamePrefix as $prefix ) {
551 - if ( substr( $partname, 0, strlen( $prefix ) ) == $prefix ) {
552 - $warning .= '<li>' . wfMsgExt( 'filename-prefix', 'parseinline', $prefix ) . '</li>';
553 - break;
554 - }
 547+ $filenamePrefixBlacklist = self::getFilenamePrefixBlacklist();
 548+ # Do the match
 549+ foreach( $filenamePrefixBlacklist as $prefix ) {
 550+ if ( substr( $partname, 0, strlen( $prefix ) ) == $prefix ) {
 551+ $warning .= '<li>' . wfMsgExt( 'filename-bad-prefix', 'parseinline', $prefix ) . '</li>';
 552+ break;
555553 }
556554 }
557555
@@ -608,13 +606,14 @@
609607 }
610608
611609 /**
612 - * Get a list of filename prefixes from [[MediaWiki:filename-prefix-list]]
 610+ * Get a list of blacklisted filename prefixes from [[MediaWiki:filename-prefix-blacklist]]
613611 *
614612 * @return array list of prefixes
615613 */
616 - public static function getFilenamePrefix() {
617 - $message = wfMsgForContent( 'filename-prefix-list' );
618 - if( $message && !( wfEmptyMsg( 'filename-prefix-list', $message ) || $message == '-' ) ) {
 614+ public static function getFilenamePrefixBlacklist() {
 615+ $blacklist = array();
 616+ $message = wfMsgForContent( 'filename-prefix-blacklist' );
 617+ if( $message && !( wfEmptyMsg( 'filename-prefix-blacklist', $message ) || $message == '-' ) ) {
619618 $lines = explode( "\n", $message );
620619 foreach( $lines as $line ) {
621620 // Remove comment lines
@@ -627,12 +626,10 @@
628627 if ( $comment > 0 ) {
629628 $line = substr( $line, 0, $comment-1 );
630629 }
631 - $filenamePrefix[] = trim( $line );
 630+ $blacklist[] = trim( $line );
632631 }
633 - } else {
634 - $filenamePrefix = array();
635632 }
636 - return $filenamePrefix;
 633+ return $blacklist;
637634 }
638635
639636 /**
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -1422,8 +1422,8 @@
14231423 'destfilename' => 'Destination filename',
14241424 'watchthisupload' => 'Watch this page',
14251425 'filewasdeleted' => 'A file of this name has been previously uploaded and subsequently deleted. You should check the $1 before proceeding to upload it again.',
1426 -'filename-prefix' => 'The name of the file you are uploading begins with <strong>"$1"</strong>, which is a non-descriptive name typically assigned automatically by digital cameras. Please choose a more descriptive name for your file.',
1427 -'filename-prefix-list' => ' #<!-- leave this line exactly as it is --> <pre>
 1426+'filename-bad-prefix' => 'The name of the file you are uploading begins with <strong>"$1"</strong>, which is a non-descriptive name typically assigned automatically by digital cameras. Please choose a more descriptive name for your file.',
 1427+'filename-prefix-blacklist' => ' #<!-- leave this line exactly as it is --> <pre>
14281428 # Syntax is as follows:
14291429 # * Everything from a "#" character to the end of the line is a comment
14301430 # * Every non-blank line is a prefix for typical file names assigned automatically by digital cameras
Index: trunk/phase3/languages/messages/MessagesDa.php
@@ -1045,7 +1045,7 @@
10461046 'destfilename' => 'Målnavn',
10471047 'watchthisupload' => 'Overvåge denne side',
10481048 'filewasdeleted' => 'En fil med dette navn er tidligere uploadet og i mellemtiden slettet igen. Kontroller først indførslen i $1, før du gemmer filen.',
1049 -'filename-prefix' => 'Navnet på filen du er ved at lægge op begynder med <strong>"$1"</strong>. Dette er et ikkebeskrivende navn, der typisk er skabt automatisk af et digitalkamera. Vær venlig at vælge et mere beskrivende navn på dit billede.',
 1049+'filename-bad-prefix' => 'Navnet på filen du er ved at lægge op begynder med <strong>"$1"</strong>. Dette er et ikkebeskrivende navn, der typisk er skabt automatisk af et digitalkamera. Vær venlig at vælge et mere beskrivende navn på dit billede.',
10501050
10511051 'upload-proto-error' => 'Forkert protokol',
10521052 'upload-proto-error-text' => 'Adressen skal begynde med <code>http://</code> eller <code>ftp://</code>.',
Index: trunk/phase3/languages/messages/MessagesDe.php
@@ -1073,7 +1073,7 @@
10741074 'destfilename' => 'Zielname',
10751075 'watchthisupload' => 'Diese Seite beobachten',
10761076 'filewasdeleted' => 'Eine Datei mit diesem Namen wurde schon einmal hochgeladen und zwischenzeitlich wieder gelöscht. Bitte prüfe zuerst den Eintrag im $1, bevor du die Datei wirklich speicherst.',
1077 -'filename-prefix' => 'Der Dateiname beginnt mit <strong>„$1“</strong>. Dies ist im allgemeinen der von einer Digitalkamera vorgegebener Dateiname und daher nicht sehr aussagekräftig.
 1077+'filename-bad-prefix' => 'Der Dateiname beginnt mit <strong>„$1“</strong>. Dies ist im allgemeinen der von einer Digitalkamera vorgegebener Dateiname und daher nicht sehr aussagekräftig.
10781078 Bitte gebe der Datei einen Namen, der den Inhalt besser beschreibt.',
10791079
10801080 'upload-proto-error' => 'Falsches Protokoll',

Follow-up revisions

RevisionCommit summaryAuthorDate
r25754Merged revisions 25607-25751 via svnmerge from...david23:02, 10 September 2007

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r25620* Add a warning for non-descriptive filenames at Special:Upload...raymond08:42, 7 September 2007

Status & tagging log