r25635 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25634‎ | r25635 | r25636 >
Date:13:30, 7 September 2007
Author:brion
Status:old
Tags:
Comment:
Revert 25602 and 25604 schema changes for now.
Please don't commit schema changes to trunk until you've cleared them with me and Tim -- remember trunk is meant to be ready-to-run live at all times.
They force operational work before we can update the software again, and it's a big pain in the ass to deal with them unexpectedly.
Modified paths:
  • /trunk/phase3/includes/Article.php (modified) (history)
  • /trunk/phase3/maintenance/archives/patch-rev_bot.sql (deleted) (history)
  • /trunk/phase3/maintenance/archives/patch-revision-user-page-index.sql (deleted) (history)
  • /trunk/phase3/maintenance/tables.sql (modified) (history)
  • /trunk/phase3/maintenance/updaters.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/archives/patch-rev_bot.sql
@@ -1,5 +0,0 @@
2 -ALTER TABLE /*$wgDBprefix*/revision
3 - ADD COLUMN rev_bot tinyint unsigned NOT NULL default 0 AFTER rev_deleted;
Index: trunk/phase3/maintenance/archives/patch-revision-user-page-index.sql
@@ -1,5 +0,0 @@
2 -
3 -ALTER TABLE /*$wgDBprefix*/revision
4 - ADD INDEX page_user_timestamp (rev_page,rev_user,rev_timestamp);
Index: trunk/phase3/maintenance/updaters.inc
@@ -83,7 +83,6 @@
8484 array( 'oldimage', 'oi_metadata', 'patch-oi_metadata.sql'),
8585 array( 'archive', 'ar_page_id', 'patch-archive-page_id.sql'),
8686 array( 'image', 'img_sha1', 'patch-img_sha1.sql' ),
87 - array( 'revision', 'rev_bot', 'patch-rev_bot.sql' ),
8887 );
8988
9089 # For extensions only, should be populated via hooks
@@ -1032,8 +1031,6 @@
10331032
10341033 do_oldimage_user_index(); flush ();
10351034
1036 - do_revision_page_user_index(); flush ();
1037 -
10381035 echo "Deleting old default messages (this may take a long time!)..."; flush();
10391036 deleteDefaultMessages();
10401037 echo "Done\n"; flush();
@@ -1132,17 +1129,6 @@
11331130
11341131 }
11351132
1136 -function do_revision_page_user_index() {
1137 - global $wgDatabase;
1138 - if( $wgDatabase->indexExists( 'revision', 'page_user_timestamp' ) ) {
1139 - echo "...page,user,timestamp key on revision already exists.\n";
1140 - } else {
1141 - echo "Adding page,user,timestamp key on revision table... ";
1142 - dbsource( archive("patch-revision-user-page-index.sql"), $wgDatabase );
1143 - echo "ok\n";
1144 - }
1145 -}
1146 -
11471133 function
11481134 pg_describe_table($table)
11491135 {
Index: trunk/phase3/maintenance/tables.sql
@@ -270,9 +270,6 @@
271271 -- Not yet used; reserved for future changes to the deletion system.
272272 rev_deleted tinyint unsigned NOT NULL default '0',
273273
274 - -- Was this edit made by a bot (and marked as such)?
275 - rev_bot tinyint unsigned NOT NULL default '0',
276 -
277274 -- Length of this revision in bytes
278275 rev_len int unsigned,
279276
@@ -285,8 +282,7 @@
286283 INDEX rev_timestamp (rev_timestamp),
287284 INDEX page_timestamp (rev_page,rev_timestamp),
288285 INDEX user_timestamp (rev_user,rev_timestamp),
289 - INDEX usertext_timestamp (rev_user_text,rev_timestamp),
290 - INDEX page_user_timestamp (rev_page,rev_user,rev_timestamp)
 286+ INDEX usertext_timestamp (rev_user_text,rev_timestamp)
291287
292288 ) /*$wgDBTableOptions*/ MAX_ROWS=10000000 AVG_ROW_LENGTH=1024;
293289 -- In case tables are created as MyISAM, use row hints for MySQL <5.0 to avoid 4GB limit
Index: trunk/phase3/includes/Article.php
@@ -2463,8 +2463,8 @@
24642464 *
24652465 * @param Revision $rev
24662466 *
2467 - * @todo This is a lousy interface function. Kill it and replace the
2468 - * other cruddy functions like editUpdates and such so it's not needed
 2467+ * @todo This is a shitty interface function. Kill it and replace the
 2468+ * other shitty functions like editUpdates and such so it's not needed
24692469 * anymore.
24702470 */
24712471 function createUpdates( $rev ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r25754Merged revisions 25607-25751 via svnmerge from...david23:02, 10 September 2007

Status & tagging log