r25605 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r25604‎ | r25605 | r25606 >
Date:04:02, 7 September 2007
Author:tstarling
Status:old
Tags:
Comment:
You might find email to be more efficient for sending private messages -- that way only the recipient downloads it, instead of the recipient plus 100 million Wikipedia readers. Or indeed, a commit notice. With a large file in the data parameter in Mozilla, the browser downloads the entire file before it starts playing. The referenced document may describe streaming, but the same technique is also necessary for cross-browser progressive download.
Modified paths:
  • /trunk/extensions/OggHandler/OggPlayer.js (modified) (history)

Diff [purge]

Index: trunk/extensions/OggHandler/OggPlayer.js
——@@ -499,10 +499,6 @@
500500 // Use QTSRC parameter instead of data attribute to allow progressive download
501501 // The data attribute and src parameter point to a small file, as recommended in
502502 // http://developer.apple.com/documentation/QuickTime/Conceptual/QTScripting_HTML/QTScripting_HTML_Document/chapter_1000_section_6.html
503 - // (Actually that's supposed to be for streaming, you're not supposed to need
504 - // anything fancy for progressive download. But sometimes it doesn't start playing
505 - // properly if you don't use this trick. Also don't forget to use an empty .mov file
506 - // rather than an extensionless file, or Opera prompts you to download it.)
507503 " data=" + this.hq( this.extPathUrl + '/null_file.mov' ) +
508504 ">" +
509505 // Scale, don't clip

Status & tagging log