r25600 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25599‎ | r25600 | r25601 >
Date:00:23, 7 September 2007
Author:brion
Status:old
Tags:
Comment:
Rename the null file for QuickTime hack to null_file.mov so Opera doesn't prompt to download it
Modified paths:
  • /trunk/extensions/OggHandler/OggHandler.php (modified) (history)
  • /trunk/extensions/OggHandler/OggPlayer.js (modified) (history)
  • /trunk/extensions/OggHandler/null_file.mov (added) (history)

Diff [purge]

Index: trunk/extensions/OggHandler/OggHandler.php
@@ -17,7 +17,7 @@
1818 ini_get( 'include_path' ) );
1919
2020 // Bump this when updating OggPlayer.js to help update caches
21 -$wgOggScriptVersion = '1';
 21+$wgOggScriptVersion = '3';
2222
2323 $wgExtensionMessagesFiles['OggHandler'] = "$oggDir/OggHandler.i18n.php";
2424 $wgParserOutputHooks['OggHandler'] = array( 'OggHandler', 'outputHook' );
Index: trunk/extensions/OggHandler/OggPlayer.js
@@ -499,12 +499,16 @@
500500 // Use QTSRC parameter instead of data attribute to allow progressive download
501501 // The data attribute and src parameter point to a small file, as recommended in
502502 // http://developer.apple.com/documentation/QuickTime/Conceptual/QTScripting_HTML/QTScripting_HTML_Document/chapter_1000_section_6.html
503 - " data=" + this.hq( this.extPathUrl + '/null_file' ) +
 503+ // (Actually that's supposed to be for streaming, you're not supposed to need
 504+ // anything fancy for progressive download. But sometimes it doesn't start playing
 505+ // properly if you don't use this trick. Also don't forget to use an empty .mov file
 506+ // rather than an extensionless file, or Opera prompts you to download it.)
 507+ " data=" + this.hq( this.extPathUrl + '/null_file.mov' ) +
504508 ">" +
505509 // Scale, don't clip
506510 "<param name='SCALE' value='Aspect'/>" +
507511 "<param name='AUTOPLAY' value='True'/>" +
508 - "<param name='src' value=" + this.hq( this.extPathUrl + '/null_file' ) + "/>" +
 512+ "<param name='src' value=" + this.hq( this.extPathUrl + '/null_file.mov' ) + "/>" +
509513 "<param name='QTSRC' value=" + this.hq( params.videoUrl ) + "/>" +
510514 "</object></div>";
511515
Index: trunk/extensions/OggHandler/null_file.mov

Status & tagging log