r25516 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25515‎ | r25516 | r25517 >
Date:03:00, 5 September 2007
Author:tstarling
Status:old
Tags:
Comment:
-ss must be specified before -i, to enable fast seek. But see http://bugzilla.mplayerhq.hu/show_bug.cgi?id=892 .
Modified paths:
  • /trunk/extensions/OggHandler/OggHandler_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OggHandler/OggHandler_body.php
@@ -230,11 +230,11 @@
231231 wfDebug( "Creating video thumbnail at $dstPath\n" );
232232
233233 $cmd = wfEscapeShellArg( $wgFFmpegLocation ) .
 234+ ' -ss ' . intval( $thumbTime ) . ' ' .
234235 ' -i ' . wfEscapeShellArg( $file->getPath() ) .
235236 # MJPEG, that's the same as JPEG except it's supported by the windows build of ffmpeg
236237 # No audio, one frame
237 - ' -f mjpeg -an -vframes 1' .
238 - ' -ss ' . intval( $thumbTime ) . ' ' .
 238+ ' -f mjpeg -an -vframes 1 ' .
239239 wfEscapeShellArg( $dstPath ) . ' 2>&1';
240240
241241 $retval = 0;

Status & tagging log