r25435 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25434‎ | r25435 | r25436 >
Date:10:21, 3 September 2007
Author:proes
Status:old
Tags:
Comment:
Removed spurious OmegaWikiAttributes::getInstance() calls from Editor.php
Modified paths:
  • /trunk/extensions/Wikidata/OmegaWiki/Editor.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Wikidata/OmegaWiki/Editor.php
@@ -1062,9 +1062,6 @@
10631063
10641064 class LinkEditor extends ShortTextEditor {
10651065 public function getViewHTML(IdStack $idPath, $value) {
1066 -
1067 - $o=OmegaWikiAttributes::getInstance();
1068 -
10691066 $label = htmlspecialchars($value->linkLabel);
10701067 $url = htmlspecialchars($value->linkURL);
10711068
@@ -1136,8 +1133,6 @@
11371134 }
11381135
11391136 public function getViewHTML(IdStack $idPath, $value) {
1140 -
1141 - $o=OmegaWikiAttributes::getInstance();
11421137 $definedMeaningId = $value->definedMeaningId;
11431138 $definedMeaningLabel = $value->definedMeaningLabel;
11441139 $definedMeaningDefiningExpression = $value->definedMeaningDefiningExpression;
@@ -1152,9 +1147,6 @@
11531148 }
11541149
11551150 public function getViewHTML(IdStack $idPath, $value) {
1156 -
1157 - $o=OmegaWikiAttributes::getInstance();
1158 -
11591151 $definedMeaningId = $value->definedMeaningId;
11601152 $definedMeaningLabel = $value->definedMeaningLabel;
11611153 $definedMeaningDefiningExpression = $value->definedMeaningDefiningExpression;
@@ -1208,9 +1200,6 @@
12091201 }
12101202
12111203 public function getViewHTML(IdStack $idPath, $value) {
1212 -
1213 - $o=OmegaWikiAttributes::getInstance();
1214 -
12151204 $definedMeaningId = $value->definedMeaningId;
12161205 $definedMeaningLabel = $value->definedMeaningLabel;
12171206 $definedMeaningDefiningExpression = $value->definedMeaningDefiningExpression;
@@ -1915,9 +1904,6 @@
19161905 }
19171906
19181907 public function getViewHTML(IdStack $idPath, $value) {
1919 -
1920 - $o=OmegaWikiAttributes::getInstance();
1921 -
19221908 $isLatest = $value->isLatest;
19231909 $operation = $value->operation;
19241910
@@ -2193,8 +2179,6 @@
21942180
21952181 class GotoSourceEditor extends Viewer {
21962182 public function view(IdStack $idPath, $value) {
2197 -
2198 - $o=OmegaWikiAttributes::getInstance();
21992183 global
22002184 $wgGotoSourceTemplates;
22012185

Status & tagging log