r25425 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25424‎ | r25425 | r25426 >
Date:08:28, 3 September 2007
Author:ilabarg1
Status:old
Tags:
Comment:
[EditPage.php]-All break cleaned of processAttemptSave.
Modified paths:
  • /branches/ApiEdit_Vodafone/includes/EditPage.php (modified) (history)

Diff [purge]

Index: branches/ApiEdit_Vodafone/includes/EditPage.php
@@ -1601,7 +1601,6 @@
16021602 //$baseRevision=true;
16031603 if( is_null( $baseRevision ) ) {
16041604 wfProfileOut( $fname );
1605 -//break;
16061605 return false;
16071606 }
16081607 $baseText = $baseRevision->getText();
@@ -2136,103 +2135,80 @@
21372136 case self::AS_END:
21382137 //wfProfileOut( $fname );
21392138 return true;
2140 - break;
2141 -
 2139+
21422140 case self::AS_SUCCESS_UPDATE:
21432141 return false;
2144 - break;
2145 -
 2142+
21462143 case self::AS_MAX_ARTICLE_SIZE_EXCEDED:
21472144 return true;
2148 - break;
2149 -
 2145+
21502146 case self::AS_TEXTBOX_EMPTY:
21512147 return true;
2152 - break;
2153 -
 2148+
21542149 case self::AS_SUMMARY_NEEDED_B:
21552150 return true;
2156 - break;
2157 -
 2151+
21582152 case self::AS_SUMMARY_NEEDED_A:
21592153 return true;
2160 - break;
2161 -
 2154+
21622155 case self::AS_CONFLICT_DETECTED:
21632156 return true;
2164 - break;
2165 -
 2157+
21662158 case self::AS_SUCCESS_NEW_ARTICLE:
21672159 return false;
2168 - break;
2169 -
 2160+
21702161 case self::AS_BLANK_ARTICLE:
21712162 $wgOut->redirect( $this->mTitle->getFullURL() );
21722163 return false;
2173 - break;
2174 -
 2164+
21752165 case self::AS_NO_CREATE_PERMISSION;
21762166 $this->noCreatePermission();
21772167 return;
2178 - break;
2179 -
 2168+
21802169 case self::AS_ARTICLE_WAS_DELETED:
21812170 return true;
2182 - break;
2183 -
 2171+
21842172 case self::AS_RATE_LIMITED:
21852173 $wgOut->rateLimited();
21862174 return false;
2187 - break;
2188 -
 2175+
21892176 case self::AS_READ_ONLY_PAGE:
21902177 $wgOut->readOnlyPage();
21912178 return false;
2192 - break;
2193 -
 2179+
21942180 case self::AS_READ_ONLY_PAGE_LOGGED:
21952181 $wgOut->readOnlyPage();
21962182 return false;
2197 - break;
2198 -
 2183+
21992184 case self::AS_READ_ONLY_PAGE_ANON:
22002185 $this->userNotLoggedInPage();
22012186 return false;
2202 - break;
2203 -
 2187+
22042188 case self::AS_CONTENT_TOO_BIG:
22052189 return true;
2206 - break;
2207 -
 2190+
22082191 case self::AS_BLOCKED_PAGE_FOR_USER:
22092192 $this->blockedPage();
22102193 return false;
2211 - break;
2212 -
 2194+
22132195 case self::AS_EXIST_HOOK_ERROR_A:
22142196 return false;
2215 - break;
2216 -
 2197+
22172198 case self::AS_SPAM_ERROR:
22182199 $this->spamPage ( $matches[0] );
22192200 return false;
2220 - break;
2221 -
 2201+
22222202 case self::AS_FILTERING:
22232203 return false;
2224 - break;
2225 -
 2204+
22262205 case self::AS_EXIST_HOOK_ERROR_B:
22272206 return false;
2228 - break;
2229 -
 2207+
22302208 case self::AS_EXIST_HOOK_ERROR_C:
22312209 return true;
2232 - break;
2233 -
 2210+
22342211 // case DEFAULT:
22352212 // return true;
2236 -// break;
22372213 }
22382214 }
22392215

Status & tagging log