r25409 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25408‎ | r25409 | r25410 >
Date:17:13, 2 September 2007
Author:tstarling
Status:old
Tags:
Comment:
In the diff column headings, Use divs with id attributes instead of <br/>, for easier site/user javascript hacks. Patch by Carl Fürstenberg.
Modified paths:
  • /trunk/phase3/includes/DifferenceEngine.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/DifferenceEngine.php
@@ -215,14 +215,14 @@
216216 wfMsg( 'minoreditletter') ) . ' ';
217217 }
218218
219 - $oldHeader = "<strong>{$this->mOldtitle}</strong><br />" .
220 - $sk->revUserTools( $this->mOldRev ) . "<br />" .
221 - $oldminor . $sk->revComment( $this->mOldRev, !$diffOnly ) . "<br />" .
222 - $prevlink;
223 - $newHeader = "<strong>{$this->mNewtitle}</strong><br />" .
224 - $sk->revUserTools( $this->mNewRev ) . " $rollback<br />" .
225 - $newminor . $sk->revComment( $this->mNewRev, !$diffOnly ) . "<br />" .
226 - $nextlink . $patrol;
 219+ $oldHeader = '<div id="mw-diff-otitle1"><strong>' . $this->mOldtitle . '</strong></div>' .
 220+ '<div id="mw-diff-otitle2">' . $sk->revUserTools( $this->mOldRev ) . "</div>" .
 221+ '<div id="mw-diff-otitle3">' . $oldminor . $sk->revComment( $this->mOldRev, !$diffOnly ) . "</div>" .
 222+ '<div id="mw-diff-otitle4">' . $prevlink . '</div>';
 223+ $newHeader = '<div id="mw-diff-ntitle1"><strong>' .$this->mNewtitle . '</strong></div>' .
 224+ '<div id="mw-diff-ntitle2">' . $sk->revUserTools( $this->mNewRev ) . " $rollback</div>" .
 225+ '<div id="mw-diff-ntitle3">' . $newminor . $sk->revComment( $this->mNewRev, !$diffOnly ) . "</div>" .
 226+ '<div id="mw-diff-ntitle4">' . $nextlink . $patrol . '</div>';
227227
228228 $this->showDiff( $oldHeader, $newHeader );
229229
@@ -1869,3 +1869,4 @@
18701870 }
18711871
18721872
 1873+

Follow-up revisions

RevisionCommit summaryAuthorDate
r25415Merged revisions 25372-25414 via svnmerge from...david21:15, 2 September 2007

Status & tagging log