r25394 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25393‎ | r25394 | r25395 >
Date:17:57, 1 September 2007
Author:robchurch
Status:old
Tags:
Comment:
Revert r25349 and offspring; the watchlist editor shows titles, not users - a contributions link is not appropriate here, nor is it useful
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/WatchlistEditor.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES
@@ -194,7 +194,6 @@
195195 text for a non-existent page
196196 * (bug 11022) Use a more accurate page title for Special:Whatlinkshere and
197197 Special:Recentchangeslinked
198 -* Add link to user contributions in normal watchlist edit mode
199198
200199 == Bugfixes since 1.10 ==
201200
Index: trunk/phase3/includes/WatchlistEditor.php
@@ -411,12 +411,8 @@
412412 if( $redirect )
413413 $link = '<span class="watchlistredir">' . $link . '</span>';
414414 $tools[] = $skin->makeLinkObj( $title->getTalkPage(), wfMsgHtml( 'talkpagelinktext' ) );
415 - if( $title->exists() ) {
 415+ if( $title->exists() )
416416 $tools[] = $skin->makeKnownLinkObj( $title, wfMsgHtml( 'history_short' ), 'action=history' );
417 - }
418 - if( $title->getNamespace() == NS_USER && !$title->isSubpage() ) {
419 - $tools[] = $skin->makeKnownLinkObj( SpecialPage::getTitleFor( 'Contributions', $title->getText() ), wfMsgHtml( 'contributions' ) );
420 - }
421417 return '<li>'
422418 . Xml::check( 'titles[]', false, array( 'value' => $title->getPrefixedText() ) )
423419 . $link . ' (' . implode( ' | ', $tools ) . ')' . '</li>';

Follow-up revisions

RevisionCommit summaryAuthorDate
r25415Merged revisions 25372-25414 via svnmerge from...david21:15, 2 September 2007

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r25349* Add link to user contributions in normal watchlist edit moderaymond11:10, 31 August 2007

Status & tagging log