r25380 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25379‎ | r25380 | r25381 >
Date:21:46, 31 August 2007
Author:david
Status:old
Tags:
Comment:
Fixed wrong article regression. Todo: better terminology for root/article/talkpage/permalink.
Modified paths:
  • /branches/liquidthreads/extensions/LqtPages.php (modified) (history)

Diff [purge]

Index: branches/liquidthreads/extensions/LqtPages.php
@@ -407,7 +407,7 @@
408408 // TODO this is a holdover from the special page; not sure what's correct here.
409409 // we now have a real true $this->article that makes some sense.
410410 // but we still want to know about $t->article.
411 -// $this->article = $t->article(); # for creating reply threads.
 411+ $this->article = $t->article(); # for creating reply threads.
412412
413413 }
414414
@@ -652,6 +652,8 @@
653653 // TODO this is a holdover from the special page; not sure what's correct here.
654654 // we now have a real true $this->article that makes some sense.
655655 // but we still want to know about $t->article.
 656+ // $this->article gets saved to thread_article, so we want it to point to the
 657+ // subject page associated with the talkpage, always, not the permalink url.
656658 // $this->article = $t->article(); # for creating reply threads.
657659
658660 $this->output->setSubtitle("Viewing a history listing.");

Status & tagging log