r25290 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25289‎ | r25290 | r25291 >
Date:15:30, 29 August 2007
Author:brion
Status:old
Tags:
Comment:
Revert schema change in r25267 -- no more schema changes right before release please.
Modified paths:
  • /trunk/phase3/includes/Article.php (modified) (history)
  • /trunk/phase3/maintenance/archives/patch-revision-user-page-index.sql (deleted) (history)
  • /trunk/phase3/maintenance/tables.sql (modified) (history)
  • /trunk/phase3/maintenance/updaters.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/archives/patch-revision-user-page-index.sql
@@ -1,5 +0,0 @@
2 -
3 -ALTER TABLE /*$wgDBprefix*/revision
4 - ADD INDEX page_user_timestamp (rev_page,rev_user,rev_timestamp);
Index: trunk/phase3/maintenance/updaters.inc
@@ -1032,8 +1032,6 @@
10331033
10341034 do_oldimage_user_index(); flush ();
10351035
1036 - do_revision_page_user_index(); flush ();
1037 -
10381036 echo "Deleting old default messages (this may take a long time!)..."; flush();
10391037 deleteDefaultMessages();
10401038 echo "Done\n"; flush();
@@ -1132,17 +1130,6 @@
11331131
11341132 }
11351133
1136 -function do_revision_page_user_index() {
1137 - global $wgDatabase;
1138 - if( $wgDatabase->indexExists( 'revision', 'page_user_timestamp' ) ) {
1139 - echo "...page,user,timestamp key on revision already exists.\n";
1140 - } else {
1141 - echo "Adding page,user,timestamp key on revision table... ";
1142 - dbsource( archive("patch-revision-user-page-index.sql"), $wgDatabase );
1143 - echo "ok\n";
1144 - }
1145 -}
1146 -
11471134 function
11481135 pg_describe_table($table)
11491136 {
@@ -1542,4 +1529,4 @@
15431530 }
15441531
15451532 return;
1546 -}
 1533+}
\ No newline at end of file
Index: trunk/phase3/maintenance/tables.sql
@@ -282,8 +282,7 @@
283283 INDEX rev_timestamp (rev_timestamp),
284284 INDEX page_timestamp (rev_page,rev_timestamp),
285285 INDEX user_timestamp (rev_user,rev_timestamp),
286 - INDEX usertext_timestamp (rev_user_text,rev_timestamp),
287 - INDEX page_user_timestamp (rev_page,rev_user,rev_timestamp)
 286+ INDEX usertext_timestamp (rev_user_text,rev_timestamp)
288287
289288 ) /*$wgDBTableOptions*/ MAX_ROWS=10000000 AVG_ROW_LENGTH=1024;
290289 -- In case tables are created as MyISAM, use row hints for MySQL <5.0 to avoid 4GB limit
Index: trunk/phase3/includes/Article.php
@@ -2461,8 +2461,8 @@
24622462 *
24632463 * @param Revision $rev
24642464 *
2465 - * @todo This is a lousy interface function. Kill it and replace the
2466 - * other cruddy functions like editUpdates and such so it's not needed
 2465+ * @todo This is a shitty interface function. Kill it and replace the
 2466+ * other shitty functions like editUpdates and such so it's not needed
24672467 * anymore.
24682468 */
24692469 function createUpdates( $rev ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r25303Merged revisions 25215-25302 via svnmerge from...david07:10, 30 August 2007

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r25267* Add an index to (rev_page,rev_user,rev_timestamp) for use in "All edits by ...simetrical02:33, 29 August 2007

Status & tagging log