r25287 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25286‎ | r25287 | r25288 >
Date:13:54, 29 August 2007
Author:erik
Status:old
Tags:
Comment:
simplify constructor for now as it broke existing configurations - difference
between $caption and $propertyCaption needs to be documented if it is to be restored.
Modified paths:
  • /trunk/extensions/Wikidata/OmegaWiki/PropertyToColumnFilter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Wikidata/OmegaWiki/PropertyToColumnFilter.php
@@ -7,12 +7,12 @@
88 protected $attribute; // Attribute
99 protected $propertyCaption; // Caption of the first column
1010
11 - public function __construct($identifier, $caption, $propertyCaption, array $attributeIDs) {
12 - $this->attributeIDs = $attributeIDs;
13 - $this->attribute = new Attribute($identifier, $caption, "will-be-specified-later");
14 - $this->propertyCaption = $propertyCaption;
15 - }
16 -
 11+ public function __construct($identifier, $propertyCaption, array $attributeIDs) {
 12+ $this->attributeIDs = $attributeIDs;
 13+ $this->attribute = new Attribute($identifier, $propertyCaption, "will-be-specified-later");
 14+ $this->propertyCaption = $propertyCaption;
 15+ }
 16+
1717 public function getAttribute() {
1818 return $this->attribute;
1919 }

Status & tagging log