r25246 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25245‎ | r25246 | r25247 >
Date:16:59, 28 August 2007
Author:robchurch
Status:old
Tags:
Comment:
* (bug 10985) Compromise solution; strike out resolved cached entries to avoid breaking paging - fancier solutions can wait
* Tweak "doubleredirectstext"
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SpecialDoubleRedirects.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialDoubleRedirects.php
@@ -63,6 +63,7 @@
6464
6565 $fname = 'DoubleRedirectsPage::formatResult';
6666 $titleA = Title::makeTitle( $result->namespace, $result->title );
 67+ $linkA = $skin->makeKnownLinkObj( $titleA,'', 'redirect=no' );
6768
6869 if ( $result && !isset( $result->nsb ) ) {
6970 $dbr = wfGetDB( DB_SLAVE );
@@ -74,13 +75,12 @@
7576 }
7677 }
7778 if ( !$result ) {
78 - return '';
 79+ return "<s>{$linkA}</s>\n";
7980 }
8081
8182 $titleB = Title::makeTitle( $result->nsb, $result->tb );
8283 $titleC = Title::makeTitle( $result->nsc, $result->tc );
8384
84 - $linkA = $skin->makeKnownLinkObj( $titleA,'', 'redirect=no' );
8585 $edit = $skin->makeBrokenLinkObj( $titleA, "(".wfMsg("qbedit").")" , 'redirect=no');
8686 $linkB = $skin->makeKnownLinkObj( $titleB, '', 'redirect=no' );
8787 $linkC = $skin->makeKnownLinkObj( $titleC );
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -1560,7 +1560,7 @@
15611561
15621562 'doubleredirects' => 'Double redirects',
15631563 'doubleredirects-summary' => '', # only translate this message to other languages if you have to change it
1564 -'doubleredirectstext' => 'Each row contains links to the first and second redirect, as well as the target of the second redirect, which is usually "real" target page, which the first redirect should point to.',
 1564+'doubleredirectstext' => 'This page lists pages which redirect to other redirect pages. Each row contains links to the first and second redirect, as well as the target of the second redirect, which is usually "real" target page, which the first redirect should point to.',
15651565
15661566 'brokenredirects' => 'Broken redirects',
15671567 'brokenredirects-summary' => '', # only translate this message to other languages if you have to change it
Index: trunk/phase3/RELEASE-NOTES
@@ -422,8 +422,9 @@
423423 * (bug 11082) Fix check for fully-specced table names in Database::tableName
424424 * (bug 11067) Fix regression in upload conflict thumbnail display
425425 * (bug 11072) Fix regression in API image history query
 426+* (bug 10985) Resolved cached entries on Special:DoubleRedirects were being
 427+ supressed, breaking paging - now strikes out "fixed" results
426428
427 -
428429 == API changes since 1.10 ==
429430
430431 Full API documentation is available at http://www.mediawiki.org/wiki/API

Follow-up revisions

RevisionCommit summaryAuthorDate
r25303Merged revisions 25215-25302 via svnmerge from...david07:10, 30 August 2007

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r25037(bug 10985) Special:DoubleRedirects was omitting "fixed" results when cached,...robchurch07:08, 22 August 2007
r25109Merged revisions 25016-25108 via svnmerge from...david07:30, 24 August 2007

Status & tagging log