r25236 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25235‎ | r25236 | r25237 >
Date:15:31, 28 August 2007
Author:robchurch
Status:old
Tags:
Comment:
(bug 11095) Honour "preview on first edit" preference when preloading text for a non-existent page
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -449,7 +449,7 @@
450450 } elseif( $this->section == 'new' ) {
451451 // Nothing *to* preview for new sections
452452 return false;
453 - } elseif( $this->mTitle->exists() && $wgUser->getOption( 'previewonfirst' ) ) {
 453+ } elseif( ( $wgRequest->getVal( 'preload' ) !== '' || $this->mTitle->exists() ) && $wgUser->getOption( 'previewonfirst' ) ) {
454454 // Standard preference behaviour
455455 return true;
456456 } elseif( !$this->mTitle->exists() && $this->mTitle->getNamespace() == NS_CATEGORY ) {
Index: trunk/phase3/RELEASE-NOTES
@@ -190,6 +190,8 @@
191191 * Add accesskey 's' and tooltip to 'upload file' button at Special:Upload
192192 * Introduced 'SkinAfterBottomScripts' hook; see docs/hooks.txt for
193193 more information
 194+* (bug 11095) Honour "preview on first edit" preference when preloading
 195+ text for a non-existent page
194196
195197 == Bugfixes since 1.10 ==
196198

Follow-up revisions

RevisionCommit summaryAuthorDate
r25303Merged revisions 25215-25302 via svnmerge from...david07:10, 30 August 2007

Status & tagging log