r25204 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25203‎ | r25204 | r25205 >
Date:18:56, 27 August 2007
Author:brion
Status:old
Tags:
Comment:
* (bug 11082) Fix check for fully-specced table names in Database::tableName
strpos() was in wrong order since added in 2004 :D
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Database.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Database.php
@@ -1582,7 +1582,7 @@
15831583 global $wgSharedDB;
15841584 # Skip quoted literals
15851585 if ( $name{0} != '`' ) {
1586 - if ( $this->mTablePrefix !== '' && strpos( '.', $name ) === false ) {
 1586+ if ( $this->mTablePrefix !== '' && strpos( $name, '.' ) === false ) {
15871587 $name = "{$this->mTablePrefix}$name";
15881588 }
15891589 if ( isset( $wgSharedDB ) && "{$this->mTablePrefix}user" == $name ) {
Index: trunk/phase3/RELEASE-NOTES
@@ -419,7 +419,9 @@
420420 * Double encoding broke Special:Newpages for some languages
421421 * Adding a newline before the statistics footer, to prevent parsing problems
422422 * Preventing the TOC from appearing in Special:Statistics
 423+* (bug 11082) Fix check for fully-specced table names in Database::tableName
423424
 425+
424426 == API changes since 1.10 ==
425427
426428 Full API documentation is available at http://www.mediawiki.org/wiki/API

Follow-up revisions

RevisionCommit summaryAuthorDate
r25223Merged revisions 25126-25214 via svnmerge from...david07:39, 28 August 2007

Status & tagging log