r25197 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25196‎ | r25197 | r25198 >
Date:15:11, 27 August 2007
Author:raymond
Status:old
Tags:
Comment:
Add a version number to proofread.js
Bump it every time you change the js.
Modified paths:
  • /trunk/extensions/ProofreadPage/ProofreadPage.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ProofreadPage/ProofreadPage.php
@@ -14,6 +14,9 @@
1515 'description' => 'Allow easy comparison of text to the original scan',
1616 );
1717
 18+# Bump the version number every time you change proofread.js
 19+$wgProofreadPageVersion = 1;
 20+
1821 /**
1922 *
2023 * Query the database to find if the current page is referred in an
@@ -86,7 +89,7 @@
8790 */
8891
8992 function wfProofreadPageParserOutput( &$out, &$pout ) {
90 - global $wgTitle, $wgJsMimeType, $wgScriptPath, $wgRequest;
 93+ global $wgTitle, $wgJsMimeType, $wgScriptPath, $wgRequest, $wgProofreadPageVersion;
9194
9295 wfProofreadPageLoadMessages();
9396 $action = $wgRequest->getVal('action');
@@ -133,7 +136,7 @@
134137 $thumbURL = '';
135138 }
136139
137 - $jsFile = htmlspecialchars( "$wgScriptPath/extensions/ProofreadPage/proofread.js" );
 140+ $jsFile = htmlspecialchars( "$wgScriptPath/extensions/ProofreadPage/proofread.js?$wgProofreadPageVersion" );
138141
139142 $out->addScript( <<<EOT
140143 <script type="$wgJsMimeType">

Status & tagging log