r25188 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25187‎ | r25188 | r25189 >
Date:11:24, 27 August 2007
Author:raymond
Status:old
Tags:
Comment:
Fix a regression from r24808 for some image options.
Thanks for hints from VP in de.wp.
Modified paths:
  • /trunk/phase3/includes/Linker.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Linker.php
@@ -530,13 +530,13 @@
531531 }
532532
533533 // Reduce width for upright images when parameter 'upright' is used
534 - if ( !isset( $fp['upright_factor'] ) || $fp['upright_factor'] == 0 ) {
535 - $fp['upright_factor'] = $wgThumbUpright;
 534+ if ( isset( $fp['upright'] ) && $fp['upright'] == 0 ) {
 535+ $fp['upright'] = $wgThumbUpright;
536536 }
537537 // Use width which is smaller: real image width or user preference width
538538 // For caching health: If width scaled down due to upright parameter, round to full __0 pixel to avoid the creation of a lot of odd thumbs
539539 $prefWidth = isset( $fp['upright'] ) ?
540 - round( $wgThumbLimits[$wopt] * $fp['upright_factor'], -1 ) :
 540+ round( $wgThumbLimits[$wopt] * $fp['upright'], -1 ) :
541541 $wgThumbLimits[$wopt];
542542 if ( $hp['width'] <= 0 || $prefWidth < $hp['width'] ) {
543543 $hp['width'] = $prefWidth;
@@ -544,7 +544,7 @@
545545 }
546546 }
547547
548 - if ( isset( $fp['thumbnail'] ) || isset( $fp['framed'] ) ) {
 548+ if ( isset( $fp['thumbnail'] ) || isset( $fp['manualthumb'] ) || isset( $fp['framed'] ) ) {
549549
550550 # Create a thumbnail. Alignment depends on language
551551 # writing direction, # right aligned for left-to-right-

Follow-up revisions

RevisionCommit summaryAuthorDate
r25223Merged revisions 25126-25214 via svnmerge from...david07:39, 28 August 2007

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r24808Basic integrated audio/video support, with Ogg implementation....tstarling10:50, 15 August 2007

Status & tagging log