r25179 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25178‎ | r25179 | r25180 >
Date:22:40, 26 August 2007
Author:tlaqua
Status:old
Tags:
Comment:
Stop pop up div from overlapping footer. Still need to test in Opera and Safari, good in FF2 & IE7.
Modified paths:
  • /trunk/extensions/ContributorsAddon/ContributorsAddon.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ContributorsAddon/ContributorsAddon.js
@@ -28,6 +28,9 @@
2929 var contributorsDiv = document.getElementById('contributorsDiv');
3030 contributorsDiv.className = 'contributorsDivShow pBody';
3131 var arrCoords = findPos(document.getElementById('t-contributors'));
 32+ var arrFooterPos = findPos(document.getElementById('footer'));
 33+ if (arrCoords[1] + contributorsDiv.clientHeight > arrFooterPos[1])
 34+ arrCoords[1] = arrFooterPos[1] - contributorsDiv.clientHeight;
3235 contributorsDiv.style.top = (arrCoords[1]-5) + 'px';
3336 contributorsDiv.style.left = (arrCoords[0]+40) + 'px';
3437 }

Status & tagging log