r25175 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25174‎ | r25175 | r25176 >
Date:21:34, 26 August 2007
Author:aaron
Status:old
Tags:
Comment:
*Rename protected-subtitle messages to something more uninformative. Tweak one message very slightly.
Modified paths:
  • /trunk/phase3/includes/Article.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
@@ -918,9 +918,9 @@
919919 if( !$editGroups || !$moveGroups ) {
920920 $msg = wfMsg( 'protected-subtitle' );
921921 } else if( $editGroups == $moveGroups ) {
922 - $msg = wfMsg( 'protected-subtitle2', $editGroups, $moveGroups );
 922+ $msg = wfMsg( 'protected-subtitle-same', $editGroups, $moveGroups );
923923 } else {
924 - $msg = wfMsg( 'protected-subtitle3', $editGroups, $moveGroups );
 924+ $msg = wfMsg( 'protected-subtitle-diff', $editGroups, $moveGroups );
925925 }
926926
927927 $wgOut->setSubtitle( $wgOut->getSubtitle() . $msg );
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -794,13 +794,13 @@
795795 'sqlhidden' => '(SQL query hidden)',
796796 'cascadeprotected' => "This page has been protected from editing, because it is included in the following {{PLURAL:$1|page|pages}}, which are protected with the \"cascading\" option turned on:
797797 $2",
798 -'namespaceprotected' => "You do not have permission to edit pages in the '''$1''' namespace.",
799 -'customcssjsprotected' => "You do not have permission to edit this page, because it contains another user's personal settings.",
800 -'ns-specialprotected' => "Pages in the {{ns:special}} namespace cannot be edited.",
801 -'protected-subtitle' => "(This page is protected)",
802 -'protected-subtitle2' => "(This page is protected. Some users ($1) can still edit or move it.)",
803 -'protected-subtitle3' => "(This page is protected. Some users ($1) can still edit it and others ($2) can move it.)",
804 -'protected-anyone' => 'anyone',
 798+'namespaceprotected' => "You do not have permission to edit pages in the '''$1''' namespace.",
 799+'customcssjsprotected' => "You do not have permission to edit this page, because it contains another user's personal settings.",
 800+'ns-specialprotected' => "Pages in the {{ns:special}} namespace cannot be edited.",
 801+'protected-subtitle' => "(This page is protected)",
 802+'protected-subtitle-same' => "(This page is protected. Some users ($1) can still edit or move it.)",
 803+'protected-subtitle-diff' => "(This page is protected. Some users ($1) can still edit it while others ($2) can move it.)",
 804+'protected-anyone' => 'anyone',
805805
806806 # Login and logout pages
807807 'logouttitle' => 'User logout',

Follow-up revisions

RevisionCommit summaryAuthorDate
r25176*On second thought, don't use 'diff', might be confusing. And I meant 'inform...aaron21:43, 26 August 2007
r25223Merged revisions 25126-25214 via svnmerge from...david07:39, 28 August 2007

Status & tagging log