r25163 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25162‎ | r25163 | r25164 >
Date:15:49, 26 August 2007
Author:kim
Status:old
Tags:
Comment:
Some wfMsg fixes.
* Some were actually from MediaWiki (so returned those to wfMsg from wfMsgSc)
* Some App.php values were actually not modified, now done.

Future:
* Is wfMsgSc actually replicating wfMsg functionality properly?
* OmegaWikiAttributes might be overweight atm. Needs restructuring.
Modified paths:
  • /trunk/extensions/Wikidata/App.php (modified) (history)
  • /trunk/extensions/Wikidata/OmegaWiki/DefinedMeaning.php (modified) (history)
  • /trunk/extensions/Wikidata/OmegaWiki/Wikidata.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Wikidata/App.php
@@ -118,7 +118,7 @@
119119 'ow_will_insert'=>"Will insert the following:",
120120 'ow_contents_of_mapping'=>'Contents of mapping',
121121 'ow_available_contexts'=>'Available contexts',
122 - 'add_concept_link'=>'Add link to other concepts',
 122+ 'ow_add_concept_link'=>'Add link to other concepts',
123123 'ow_concept_panel'=>'Concept Panel',
124124 'ow_dm_badtitle'=>'This page does not point to any DefinedMeaning (concept). Please check the web address.',
125125 'ow_dm_missing'=>'This page seems to point to a non-existent DefinedMeaning (concept). Please check the web address.',
@@ -170,7 +170,6 @@
171171 "ow_TranslatedTextAttributeValues" => "Text properties",
172172 "ow_LinkAttribute" => "Property",
173173 "ow_LinkAttributeValues" => "Links"
174 -
175174 )
176175 );
177176
Index: trunk/extensions/Wikidata/OmegaWiki/DefinedMeaning.php
@@ -237,7 +237,7 @@
238238 }
239239
240240 $datasets=wdGetDatasets();
241 - $datasetarray['']=wfMsgSc('ow_none_selected');
 241+ $datasetarray['']=wfMsgSc('none_selected');
242242 foreach($datasets as $datasetid=>$dataset) {
243243 $datasetarray[$datasetid]=$dataset->fetchName();
244244 }
Index: trunk/extensions/Wikidata/OmegaWiki/Wikidata.php
@@ -240,7 +240,7 @@
241241 $title = $this->getTitle();
242242
243243 $wgOut->setPageTitle($title);
244 - $wgOut->setPageTitle(wfMsgSc("editing",$title));
 244+ $wgOut->setPageTitle(wfMsg("editing",$title));
245245
246246 $wgOut->addHTML(
247247 '<form method="post" action="">' .
@@ -255,7 +255,7 @@
256256 $wgOut->addHTML(
257257 '<div class="option-panel">'.
258258 '<table cellpadding="0" cellspacing="0"><tr>' .
259 - '<th>' . wfMsgSc("summary") . ': </th>' .
 259+ '<th>' . wfMsg("summary") . ': </th>' .
260260 '<td class="option-field">' . getTextBox("summary") .'</td>' .
261261 '</tr></table>' .
262262 getSubmitButton("save", wfMsgSc("save")).

Status & tagging log