r25151 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25150‎ | r25151 | r25152 >
Date:04:54, 26 August 2007
Author:amidaniel
Status:old
Tags:
Comment:
(bug 10347) Added subtle message to subtitle indicating that the page currently being viewed is protected. Could perhaps be a bit more subtle by default though ...
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Article.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
@@ -740,6 +740,14 @@
741741 }
742742 }
743743
 744+ if ( $this->mTitle->isProtected() ) {
 745+ $editrestr = $this->mTitle->getRestrictions('edit');
 746+ $moverestr = $this->mTitle->getRestrictions('move');
 747+ $wgOut->setSubtitle($wgOut->getSubtitle() .
 748+ wfMsg( 'protected-subtitle',
 749+ $editrestr[0], $moverestr[0] ) );
 750+ }
 751+
744752 $outputDone = false;
745753 wfRunHooks( 'ArticleViewHeader', array( &$this, &$outputDone, &$pcache ) );
746754 if ( $pcache ) {
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -797,6 +797,7 @@
798798 'namespaceprotected' => "You do not have permission to edit pages in the '''$1''' namespace.",
799799 'customcssjsprotected' => "You do not have permission to edit this page, because it contains another user's personal settings.",
800800 'ns-specialprotected' => "Pages in the {{ns:special}} namespace cannot be edited.",
 801+'protected-subtitle' => "<!-- This message will be displayed as the subtitle for pages that are protected. The argument $1 is the level of edit-protection (i.e., sysop or autoconfirmed), and $2 is the level of move-protection. --> (This page is protected.)",
801802
802803 # Login and logout pages
803804 'logouttitle' => 'User logout',
Index: trunk/phase3/RELEASE-NOTES
@@ -412,6 +412,8 @@
413413 * Resizing transparent GIF images with GD now retains transparency by skipping
414414 resampling
415415 * (bug 11065) Fix regression in handling of wiki-formatted EXIF metadata
 416+* (bug 10347) Add subtitle message to indicate that the page being viewed is
 417+ protected.
416418
417419
418420 == API changes since 1.10 ==

Follow-up revisions

RevisionCommit summaryAuthorDate
r25210Revert bug 10347 stuff -- too-big, too-prominent, too-technical subtitle slap...brion21:05, 27 August 2007
r25223Merged revisions 25126-25214 via svnmerge from...david07:39, 28 August 2007
r42658(bug 10347) Add subtitle message for protected pagesaaron15:05, 27 October 2008
r42664Revert r42658 "(bug 10347) Add subtitle message for protected pages"...brion18:03, 27 October 2008

Status & tagging log