r25148 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25147‎ | r25148 | r25149 >
Date:22:25, 25 August 2007
Author:brion
Status:old
Tags:
Comment:
* (bug 11065) Fix regression in handling of wiki-formatted EXIF metadata
Removed a wfEscapeWikiText() in the metadata formatting code... that whole mess needs some major cleanup, though. :)
Probably escaping should happen on the _input_ somewhere in the boxels of EXIF stuff.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/media/Generic.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/media/Generic.php
@@ -195,11 +195,19 @@
196196 return false;
197197 }
198198
 199+ /**
 200+ * @fixme document this!
 201+ * 'value' thingy goes into a wikitext table; it used to be escaped but
 202+ * that was incompatible with previous practice of customized display
 203+ * with wikitext formatting via messages such as 'exif-model-value'.
 204+ * So the escaping is taken back out, but generally this seems a confusing
 205+ * interface.
 206+ */
199207 protected static function addMeta( &$array, $visibility, $type, $id, $value, $param = false ) {
200208 $array[$visibility][] = array(
201209 'id' => "$type-$id",
202210 'name' => wfMsg( "$type-$id", $param ),
203 - 'value' => wfEscapeWikiText( $value )
 211+ 'value' => $value
204212 );
205213 }
206214
Index: trunk/phase3/RELEASE-NOTES
@@ -411,6 +411,7 @@
412412 available databases in installer
413413 * Resizing transparent GIF images with GD now retains transparency by skipping
414414 resampling
 415+* (bug 11065) Fix regression in handling of wiki-formatted EXIF metadata
415416
416417
417418 == API changes since 1.10 ==

Follow-up revisions

RevisionCommit summaryAuthorDate
r25223Merged revisions 25126-25214 via svnmerge from...david07:39, 28 August 2007

Status & tagging log