r25145 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25144‎ | r25145 | r25146 >
Date:21:44, 25 August 2007
Author:tlaqua
Status:old
Tags:
Comment:
Changed $target, getMainContributors, getContributors, and getConditions from private to protected.
Modified paths:
  • /trunk/extensions/Contributors/Contributors.page.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Contributors/Contributors.page.php
@@ -9,7 +9,7 @@
1010
1111 class SpecialContributors extends IncludableSpecialPage {
1212
13 - private $target;
 13+ protected $target;
1414
1515 public function __construct() {
1616 parent::__construct( 'Contributors' );
@@ -114,7 +114,7 @@
115115 *
116116 * @return array
117117 */
118 - private function getMainContributors() {
 118+ protected function getMainContributors() {
119119 wfProfileIn( __METHOD__ );
120120 global $wgContributorsLimit, $wgContributorsThreshold;
121121 $total = 0;
@@ -137,7 +137,7 @@
138138 *
139139 * @return array
140140 */
141 - private function getContributors() {
 141+ protected function getContributors() {
142142 wfProfileIn( __METHOD__ );
143143 global $wgMemc;
144144 $k = wfMemcKey( 'contributors', $this->target->getArticleId() );
@@ -174,7 +174,7 @@
175175 *
176176 * @return array
177177 */
178 - private function getConditions() {
 178+ protected function getConditions() {
179179 global $wgVersion;
180180 $conds['rev_page'] = $this->target->getArticleId();
181181 if( version_compare( $wgVersion, '1.11alpha', '>=' ) )

Status & tagging log