r25138 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25137‎ | r25138 | r25139 >
Date:19:22, 25 August 2007
Author:aaron
Status:old
Tags:
Comment:
*oi_metadata can't be null. Some fa_metadata values are NULL since there was not always an oi_metadata to use for insertion.
Modified paths:
  • /trunk/phase3/includes/filerepo/LocalFile.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/LocalFile.php
@@ -1474,7 +1474,7 @@
14751475 'oi_user' => $row->fa_user,
14761476 'oi_user_text' => $row->fa_user_text,
14771477 'oi_timestamp' => $row->fa_timestamp,
1478 - 'oi_metadata' => $row->fa_metadata,
 1478+ 'oi_metadata' => is_null($row->fa_metadata) ? '' : $row->fa_metadata,
14791479 'oi_media_type' => $row->fa_media_type,
14801480 'oi_major_mime' => $row->fa_major_mime,
14811481 'oi_minor_mime' => $row->fa_minor_mime,

Follow-up revisions

RevisionCommit summaryAuthorDate
r25223Merged revisions 25126-25214 via svnmerge from...david07:39, 28 August 2007

Status & tagging log