r25120 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25119‎ | r25120 | r25121 >
Date:17:34, 24 August 2007
Author:aaron
Status:old
Tags:
Comment:
*Fix 'all' in namespace selector
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevsPage_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevsPage_body.php
@@ -728,7 +728,7 @@
729729 $arr = array($allnamespaces => wfMsg('namespacesall')) + $arr;
730730 }
731731
732 - $s .= "\t" . Xml::element("option", array("value" => "all"), "all") . "\n";
 732+ $s .= "\t" . Xml::element("option", array("value" => ''), wfMsg('namespacesall')) . "\n";
733733
734734 foreach($arr as $index => $name) {
735735 # Content only
@@ -755,8 +755,8 @@
756756 */
757757 class UnreviewedPagesPage extends PageQueryPage {
758758
759 - function __construct( $namespace=NULL, $showOutdated=NULL, $category=NULL ) {
760 - $this->namespace = intval($namespace);
 759+ function __construct( $namespace, $showOutdated=NULL, $category=NULL ) {
 760+ $this->namespace = $namespace=='' ? null : intval($namespace);
761761 $this->category = $category;
762762 $this->showOutdated = $showOutdated;
763763 }
@@ -798,7 +798,6 @@
799799 $sql .= "LEFT JOIN $categorylinks ON (cl_from = page_id AND cl_to = '{$category}') ";
800800 }
801801 $sql .= "WHERE ($where) ";
802 -
803802 return $sql;
804803 }
805804

Status & tagging log