r25092 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25091‎ | r25092 | r25093 >
Date:22:34, 23 August 2007
Author:tlaqua
Status:old
Tags:
Comment:
Added SkinAfterBottomScripts hook to Skin::bottomScripts(), documented in hooks.txt
Modified paths:
  • /trunk/phase3/docs/hooks.txt (modified) (history)
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/docs/hooks.txt
@@ -612,6 +612,11 @@
613613 &$siteNotice: HTML sitenotice
614614 Alter the contents of $siteNotice to add to/alter the sitenotice/anonnotice.
615615
 616+'SkinAfterBottomScripts': At the end of Skin::bottomScripts()
 617+$skin: Skin object
 618+&$text: bottomScripts Text
 619+Append to $text to add additional text/scripts after the stock bottom scripts.
 620+
616621 'SkinTemplateOutputPageBeforeExec': Before SkinTemplate::outputPage() starts page output
617622 &$sktemplate: SkinTemplate object
618623 &$tpl: Template engine object
Index: trunk/phase3/includes/Skin.php
@@ -708,7 +708,9 @@
709709 */
710710 function bottomScripts() {
711711 global $wgJsMimeType;
712 - return "\n\t\t<script type=\"$wgJsMimeType\">if (window.runOnloadHook) runOnloadHook();</script>\n";
 712+ $bottomScriptText = "\n\t\t<script type=\"$wgJsMimeType\">if (window.runOnloadHook) runOnloadHook();</script>\n";
 713+ wfRunHooks( 'SkinAfterBottomScripts', array( $this, &$bottomScriptText ) );
 714+ return $bottomScriptText;
713715 }
714716
715717 /** @return string Retrievied from HTML text */

Follow-up revisions

RevisionCommit summaryAuthorDate
r25109Merged revisions 25016-25108 via svnmerge from...david07:30, 24 August 2007

Status & tagging log