r25061 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25060‎ | r25061 | r25062 >
Date:16:47, 22 August 2007
Author:brion
Status:old
Tags:
Comment:
add a version bump variable for the js
Modified paths:
  • /trunk/extensions/OggHandler/OggHandler.php (modified) (history)
  • /trunk/extensions/OggHandler/OggHandler_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OggHandler/OggHandler.php
@@ -16,6 +16,9 @@
1717 PATH_SEPARATOR .
1818 ini_get( 'include_path' ) );
1919
 20+// Bump this when updating OggPlayer.js to help update caches
 21+$wgOggScriptVersion = '1';
 22+
2023 $wgFFmpegLocation = 'ffmpeg';
2124 $wgExtensionMessagesFiles['OggHandler'] = "$oggDir/OggHandler.i18n.php";
2225 $wgParserOutputHooks['OggHandler'] = array( 'OggHandler', 'outputHook' );
Index: trunk/extensions/OggHandler/OggHandler_body.php
@@ -309,7 +309,7 @@
310310 }
311311
312312 function setHeaders( $out ) {
313 - global $wgScriptPath, $wgCortadoJarFile;
 313+ global $wgScriptPath, $wgOggScriptVersion, $wgCortadoJarFile;
314314 if ( $out->hasHeadItem( 'OggHandler' ) ) {
315315 return;
316316 }
@@ -324,7 +324,7 @@
325325 $encCortadoUrl = Xml::encodeJsVar( "$wgScriptPath/extensions/OggHandler/$wgCortadoJarFile" );
326326
327327 $out->addHeadItem( 'OggHandler', <<<EOT
328 -<script type="text/javascript" src="$wgScriptPath/extensions/OggHandler/OggPlayer.js"></script>
 328+<script type="text/javascript" src="$wgScriptPath/extensions/OggHandler/OggPlayer.js?$wgOggScriptVersion"></script>
329329 <script type="text/javascript">
330330 wgOggPlayer.msg = $jsMsgs;
331331 wgOggPlayer.cortadoUrl = $encCortadoUrl;

Status & tagging log