r25051 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25050‎ | r25051 | r25052 >
Date:13:52, 22 August 2007
Author:tstarling
Status:old
Tags:
Comment:
Patch by Brion to make Cortado to work with multiple instances on a page.
Modified paths:
  • /trunk/extensions/OggHandler/cortado-ovt-debug-0.2.2.1-patched.jar (added) (history)
  • /trunk/extensions/OggHandler/cortado-tweak.diff (added) (history)

Diff [purge]

Index: trunk/extensions/OggHandler/cortado-ovt-debug-0.2.2.1-patched.jar
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/OggHandler/cortado-ovt-debug-0.2.2.1-patched.jar
___________________________________________________________________
Added: svn:mime-type
11 + application/octet-stream
Index: trunk/extensions/OggHandler/cortado-tweak.diff
@@ -0,0 +1,37 @@
 2+Index: src/com/fluendo/player/Cortado.java
 3+===================================================================
 4+--- src/com/fluendo/player/Cortado.java (revision 5453)
 5+@@ -30,8 +30,8 @@
 6+ MouseListener, ComponentListener, BusHandler, StatusListener, ActionListener {
 7+ private static final long serialVersionUID = 1L;
 8+
 9+- private static Cortado cortado;
 10+- private static CortadoPipeline pipeline;
 11++ private Cortado cortado;
 12++ private CortadoPipeline pipeline;
 13+
 14+ private String urlString;
 15+ private boolean audio;
 16+@@ -192,10 +192,10 @@
 17+ return res;
 18+ }
 19+
 20+- public static void shutDown(Throwable error) {
 21++ public void shutDown(Throwable error) {
 22+ Debug.log(Debug.INFO, "shutting down: reason: " + error.getMessage());
 23+ error.printStackTrace();
 24+- cortado.stop();
 25++ stop();
 26+ }
 27+
 28+ public synchronized void init() {
 29+@@ -341,7 +341,7 @@
 30+ try {
 31+ realRun();
 32+ } catch (Throwable t) {
 33+- Cortado.shutDown(t);
 34++ shutDown(t);
 35+ }
 36+ }
 37+

Status & tagging log