r25038 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25037‎ | r25038 | r25039 >
Date:07:24, 22 August 2007
Author:robchurch
Status:old
Tags:
Comment:
Tweak comment; people seem to whine about this one, not reading past the mt_rand() bit, and criticising us...
Modified paths:
  • /trunk/phase3/includes/Article.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
@@ -2403,12 +2403,11 @@
24042404 $u = new LinksUpdate( $this->mTitle, $poutput );
24052405 $u->doUpdate();
24062406
2407 - if ( wfRunHooks( 'ArticleEditUpdatesDeleteFromRecentchanges', array( &$this ) ) ) {
2408 - wfSeedRandom();
 2407+ if( wfRunHooks( 'ArticleEditUpdatesDeleteFromRecentchanges', array( &$this ) ) ) {
24092408 if ( 0 == mt_rand( 0, 99 ) ) {
2410 - # Periodically flush old entries from the recentchanges table.
 2409+ // Flush old entries from the `recentchanges` table; we do this on
 2410+ // random requests so as to avoid an increase in writes for no good reason
24112411 global $wgRCMaxAge;
2412 -
24132412 $dbw = wfGetDB( DB_MASTER );
24142413 $cutoff = $dbw->timestamp( time() - $wgRCMaxAge );
24152414 $recentchanges = $dbw->tableName( 'recentchanges' );

Follow-up revisions

RevisionCommit summaryAuthorDate
r25109Merged revisions 25016-25108 via svnmerge from...david07:30, 24 August 2007

Status & tagging log