r25036 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25035‎ | r25036 | r25037 >
Date:06:41, 22 August 2007
Author:robchurch
Status:old
Tags:
Comment:
(bug 9339) Use wfMsgExt() in OutputPage::showErrorPage() to avoid the old issue with incorrect/inconsistent message transformation and braces
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
@@ -822,9 +822,9 @@
823823 $this->mRedirect = '';
824824 $this->mBodytext = '';
825825
 826+ array_unshift( $params, 'parse' );
826827 array_unshift( $params, $msg );
827 - $message = call_user_func_array( 'wfMsg', $params );
828 - $this->addWikiText( $message );
 828+ $this->addHtml( call_user_func_array( 'wfMsgExt', $params ) );
829829
830830 $this->returnToMain( false );
831831 }
Index: trunk/phase3/RELEASE-NOTES
@@ -394,6 +394,8 @@
395395 * (bug 7890) Don't list redirects to special pages in Special:BrokenRedirects
396396 * (bug 10783) Resizing PNG-24 images causes all alpha channel transparency to be
397397 lost and transparent pixels to be turned black
 398+* (bug 9339) General error pages were transforming messages and their parameters
 399+ in the wrong order
398400
399401 == API changes since 1.10 ==
400402

Follow-up revisions

RevisionCommit summaryAuthorDate
r25109Merged revisions 25016-25108 via svnmerge from...david07:30, 24 August 2007

Status & tagging log