r25022 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25021‎ | r25022 | r25023 >
Date:00:23, 22 August 2007
Author:erik
Status:old
Tags:
Comment:
eliminate language selector - no longer needed
Modified paths:
  • /trunk/extensions/Wikidata/OmegaWiki/OmegaWikiAttributes.php (modified) (history)
  • /trunk/extensions/Wikidata/OmegaWiki/Wikidata.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Wikidata/OmegaWiki/OmegaWikiAttributes.php
@@ -367,7 +367,6 @@
368368 $instance[$viewInformation->hashCode()] = $instance["last"];
369369 }
370370 }
371 -
372371 return $instance["last"];
373372 }
374373
Index: trunk/extensions/Wikidata/OmegaWiki/Wikidata.php
@@ -14,7 +14,6 @@
1515 // The following member variables control some application specific preferences
1616 protected $filterLanguageId = 0; // Filter pages on this languageId, set to 0 to show all languages
1717 protected $possiblySynonymousRelationTypeId = 0; // Put this relation type in a special section "Possibly synonymous"
18 - protected $showLanguageSelector = true; // Show language selector at the top of each wiki data page
1918 protected $showClassicPageTitles = true; // Show classic page titles instead of prettier page titles
2019
2120 protected $propertyToColumnFilters = array();
@@ -25,16 +24,13 @@
2625
2726 public function __construct() {
2827 global
29 - $wgFilterLanguageId, $wgShowLanguageSelector,
 28+ $wgFilterLanguageId,
3029 $wgShowClassicPageTitles, $wgPossiblySynonymousRelationTypeId,
3130 $wgPropertyToColumnFilters;
3231
3332 if (isset($wgFilterLanguageId))
3433 $this->filterLanguageId = $wgFilterLanguageId;
3534
36 - if (isset($wgShowLanguageSelector))
37 - $this->showLanguageSelector = $wgShowLanguageSelector;
38 -
3935 if (isset($wgShowClassicPageTitles))
4036 $this->showClassicPageTitles = $wgShowClassicPageTitles;
4137
@@ -45,23 +41,11 @@
4642 $this->propertyToColumnFilters = $wgPropertyToColumnFilters;
4743 }
4844
49 - function getLanguageSelector() {
50 - global
51 - $wgUser;
52 -
53 - $userlang=$wgUser->getOption('language');
54 - $skin = $wgUser->getSkin();
55 -
56 - return wfMsg('ow_uilang',"<b>$userlang</b>"). " &mdash; " . $skin->makeLink("Special:Preferences", wfMsg('ow_uilang_set'));
57 - }
5845
5946 protected function outputViewHeader() {
6047 global
6148 $wgOut;
6249
63 - if ($this->showLanguageSelector)
64 - $wgOut->addHTML($this->getLanguageSelector());
65 -
6650 if($this->showDataSetPanel)
6751 $wgOut->addHTML($this->getDataSetPanel());
6852 }
@@ -177,9 +161,6 @@
178162 if ($wgRequest->getText('save') != '')
179163 $this->saveWithinTransaction();
180164
181 - if ($this->showLanguageSelector)
182 - $wgOut->addHTML($this->getLanguageSelector());
183 -
184165 $viewInformation = new ViewInformation();
185166 $viewInformation->filterLanguageId = $this->filterLanguageId;
186167 $viewInformation->possiblySynonymousRelationTypeId = $this->possiblySynonymousRelationTypeId;
@@ -227,9 +208,6 @@
228209
229210 $transactionId = $wgRequest->getInt('transaction');
230211
231 - if ($this->showLanguageSelector)
232 - $wgOut->addHTML($this->getLanguageSelector());
233 -
234212 $wgOut->addHTML(getOptionPanel(
235213 array(
236214 'Transaction' => getSuggest('transaction','transaction', array(), $transactionId, getTransactionLabel($transactionId), array(0, 2, 3)),

Status & tagging log