r25011 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r25010‎ | r25011 | r25012 >
Date:21:19, 21 August 2007
Author:brion
Status:old
Tags:
Comment:
'static' markers for the E_STRICT lovers in the house
Modified paths:
  • /trunk/extensions/CentralAuth/CentralAuthUser.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralAuth/CentralAuthUser.php
@@ -14,7 +14,7 @@
1515 class CentralAuthHelper {
1616 private static $connections = array();
1717
18 - function get( $dbname ) {
 18+ public static function get( $dbname ) {
1919 global $wgDBname;
2020 if( $dbname == $wgDBname ) {
2121 return wfGetDB( DB_MASTER );
@@ -29,7 +29,7 @@
3030 return self::$connections[$server];
3131 }
3232
33 - private function getServer( $dbname ) {
 33+ private static function getServer( $dbname ) {
3434 global $wgAlternateMaster, $wgDBserver;
3535 if( isset( $wgAlternateMaster[$dbname] ) ) {
3636 return $wgAlternateMaster[$dbname];

Status & tagging log